Commit c59443f0 authored by dbeam's avatar dbeam Committed by Commit bot

MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2382243003
Cr-Commit-Position: refs/heads/master@{#422896}
parent c537c6da
......@@ -398,6 +398,9 @@
<message name="IDS_SETTINGS_DEFAULT_BROWSER" desc="Name of the Default Browser page, which allows users to set which browser will open .html files within the OS.">
Default browser
</message>
<message name="IDS_SETTINGS_DEFAULT_BROWSER_MAKE_DEFAULT_BUTTON" desc="Text of the button used to make Chrome the default browser on the user's system.">
Make default
</message>
</if>
<!-- Bluetooth Page -->
......
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
<link rel="import" href="/default_browser_page/default_browser_browser_proxy.html">
<link rel="import" href="/icons.html">
<link rel="import" href="/settings_shared_css.html">
......@@ -14,13 +13,17 @@
}
</style>
<template is="dom-if" if="[[maySetDefaultBrowser_]]">
<div class="settings-box first two-line" on-tap="onSetDefaultBrowserTap_"
actionable>
<div class="settings-box first two-line">
<div class="start">
<div id="canBeDefaultBrowser">$i18n{defaultBrowser}</div>
<div class="secondary">$i18n{defaultBrowserMakeDefault}</div>
</div>
<button class="icon-arrow-right" is="paper-icon-button-light"></button>
<div class="secondary-action">
<paper-button class="secondary-button"
on-tap="onSetDefaultBrowserTap_">
$i18n{defaultBrowserMakeDefaultButton}
</paper-button>
</div>
</div>
</template>
<template is="dom-if" if="[[!maySetDefaultBrowser_]]">
......@@ -37,7 +40,6 @@
id="isUnknownError">
$i18n{defaultBrowserError}
</div>
<button class="icon-arrow-right" is="paper-icon-button-light"></button>
</div>
</template>
</template>
......
......@@ -469,6 +469,8 @@ void AddDefaultBrowserStrings(content::WebUIDataSource* html_source) {
{"defaultBrowser", IDS_SETTINGS_DEFAULT_BROWSER},
{"defaultBrowserDefault", IDS_SETTINGS_DEFAULT_BROWSER_DEFAULT},
{"defaultBrowserMakeDefault", IDS_SETTINGS_DEFAULT_BROWSER_MAKE_DEFAULT},
{"defaultBrowserMakeDefaultButton",
IDS_SETTINGS_DEFAULT_BROWSER_MAKE_DEFAULT_BUTTON},
{"defaultBrowserError", IDS_SETTINGS_DEFAULT_BROWSER_ERROR},
{"defaultBrowserSecondary", IDS_SETTINGS_DEFAULT_BROWSER_SECONDARY},
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment