Commit c5c7a467 authored by Michael Liao's avatar Michael Liao Committed by Commit Bot

[DevTools][Common - Data Grids - Test Fixes]: Adding required name field for...

[DevTools][Common - Data Grids - Test Fixes]: Adding required name field for all data grids + naming all data grids

Test Fixes for this CL change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891652

Change-Id: If2a5843b3efd225b4d82d55a4fd21c4d9b688afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894036
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: default avatarLorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#725687}
parent 84ffb6da
...@@ -6051,14 +6051,6 @@ crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-event-list ...@@ -6051,14 +6051,6 @@ crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-event-list
crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers.js [ Pass Failure ] crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers.js [ Pass Failure ]
crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-no-detached-iframe.js [ Pass Failure ] crbug.com/1006759 inspector-protocol/heap-profiler/heap-snapshot-with-no-detached-iframe.js [ Pass Failure ]
# Temporarily disabled for landing datagrid Changes in devtools
crbug.com/963183 http/tests/devtools/components/datagrid.js [ Pass Failure ]
crbug.com/963183 http/tests/devtools/components/viewport-datagrid.js [ Pass Failure ]
crbug.com/963183 http/tests/devtools/unit/datagrid-editable-longtext.js [ Pass Failure ]
crbug.com/963183 http/tests/devtools/unit/datagrid-items-attached-to-dom.js [ Pass Failure ]
crbug.com/963183 http/tests/devtools/unit/viewport-datagrid-items-attached-to-dom.js [ Pass Failure ]
crbug.com/963183 http/tests/devtools/unit/viewport-datagrid-items-expandable-attached-to-dom.js [ Pass Failure ]
# Temporarily disabled for landing changes to treeoutline in DevTools # Temporarily disabled for landing changes to treeoutline in DevTools
crbug.com/1033213 http/tests/devtools/security/interstitial-sidebar.js [ Pass Failure ] crbug.com/1033213 http/tests/devtools/security/interstitial-sidebar.js [ Pass Failure ]
crbug.com/1033213 http/tests/devtools/security/mixed-content-sidebar.js [ Pass Failure ] crbug.com/1033213 http/tests/devtools/security/mixed-content-sidebar.js [ Pass Failure ]
......
...@@ -40,7 +40,7 @@ ...@@ -40,7 +40,7 @@
} }
var columns = [{id: 'id'}]; var columns = [{id: 'id'}];
var dataGrid = new DataGrid.DataGrid(columns); var dataGrid = new DataGrid.DataGrid({displayName: 'Test', columns});
var a = new DataGrid.DataGridNode({id: 'a'}); var a = new DataGrid.DataGridNode({id: 'a'});
var aa = new DataGrid.DataGridNode({id: 'aa'}); var aa = new DataGrid.DataGridNode({id: 'aa'});
var aaa = new DataGrid.DataGridNode({id: 'aaa'}); var aaa = new DataGrid.DataGridNode({id: 'aaa'});
...@@ -111,7 +111,7 @@ ...@@ -111,7 +111,7 @@
dumpNodes(); dumpNodes();
var columns = [{id: 'id'}]; var columns = [{id: 'id'}];
var dataGrid = new DataGrid.DataGrid(columns); var dataGrid = new DataGrid.DataGrid({displayName: 'Test', columns});
var a = new DataGrid.DataGridNode({id: 'TextData', secondCol: 'a foo'}); var a = new DataGrid.DataGridNode({id: 'TextData', secondCol: 'a foo'});
var b = new DataGrid.DataGridNode({id: 'NullData', secondCol: null}); var b = new DataGrid.DataGridNode({id: 'NullData', secondCol: null});
var root = dataGrid.rootNode(); var root = dataGrid.rootNode();
......
...@@ -58,7 +58,7 @@ ...@@ -58,7 +58,7 @@
} }
var columns = [{id: 'id', title: 'ID column', width: '250px'}]; var columns = [{id: 'id', title: 'ID column', width: '250px'}];
var dataGrid = new DataGrid.ViewportDataGrid(columns); var dataGrid = new DataGrid.ViewportDataGrid({displayName: 'Test', columns});
var a = new DataGrid.ViewportDataGridNode({id: 'a'}); var a = new DataGrid.ViewportDataGridNode({id: 'a'});
var aa = new DataGrid.ViewportDataGridNode({id: 'aa'}); var aa = new DataGrid.ViewportDataGridNode({id: 'aa'});
var aaa = new DataGrid.ViewportDataGridNode({id: 'aaa'}); var aaa = new DataGrid.ViewportDataGridNode({id: 'aaa'});
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
{id: "key", title: "Key column", editable: true, longText: false}, {id: "key", title: "Key column", editable: true, longText: false},
{id: "value", title: "Value column", editable: true, longText: true} {id: "value", title: "Value column", editable: true, longText: true}
]; ];
var dataGrid = new DataGrid.DataGrid(columns, onEdit); var dataGrid = new DataGrid.DataGrid({displayName: 'Test', columns, editCallback: onEdit});
UI.inspectorView.element.appendChild(dataGrid.element); UI.inspectorView.element.appendChild(dataGrid.element);
var rootNode = dataGrid.rootNode(); var rootNode = dataGrid.rootNode();
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
UI.inspectorView.element.appendChild(div); UI.inspectorView.element.appendChild(div);
var columns = [{id: "id", title: "ID column", width: "250px"}]; var columns = [{id: "id", title: "ID column", width: "250px"}];
var dataGrid = new DataGrid.DataGrid(columns); var dataGrid = new DataGrid.DataGrid({displayName: 'Test', columns});
div.appendChild(dataGrid.element); div.appendChild(dataGrid.element);
dataGrid.element.style.height = '150px'; dataGrid.element.style.height = '150px';
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
UI.inspectorView.element.appendChild(div); UI.inspectorView.element.appendChild(div);
var columns = [{id: "id", title: "ID column", width: "250px"}]; var columns = [{id: "id", title: "ID column", width: "250px"}];
var dataGrid = new DataGrid.ViewportDataGrid(columns); var dataGrid = new DataGrid.ViewportDataGrid({displayName: 'Test', columns});
div.appendChild(dataGrid.element); div.appendChild(dataGrid.element);
dataGrid.element.style.height = '150px'; dataGrid.element.style.height = '150px';
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
UI.inspectorView.element.appendChild(div); UI.inspectorView.element.appendChild(div);
var columns = [{id: "id", title: "ID column", width: "250px"}]; var columns = [{id: "id", title: "ID column", width: "250px"}];
var dataGrid = new DataGrid.ViewportDataGrid(columns); var dataGrid = new DataGrid.ViewportDataGrid({displayName: 'Test', columns});
div.appendChild(dataGrid.element); div.appendChild(dataGrid.element);
dataGrid.element.style.height = '150px'; dataGrid.element.style.height = '150px';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment