Commit c5f4a017 authored by Liquan (Max) Gu's avatar Liquan (Max) Gu Committed by Commit Bot

Revert "Disabling tests in ExpandablePaymentHandlerTest"

This reverts commit 124fb902.

Reason for revert:
The tests were disabled on Marshmallow because they were caused by
crbug.com/1094008. Now that the root issue has been fixed, I am
reenabling the tests.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2274329

Bug: 1101030
Change-Id: I2e8745df2cccc4aad9f42b822f3787841679875f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380071Reviewed-by: default avatarSahel Sharify <sahel@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Reviewed-by: default avatarLiquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803592}
parent 31c668da
...@@ -14,7 +14,6 @@ import static androidx.test.espresso.matcher.ViewMatchers.withContentDescription ...@@ -14,7 +14,6 @@ import static androidx.test.espresso.matcher.ViewMatchers.withContentDescription
import static androidx.test.espresso.matcher.ViewMatchers.withId; import static androidx.test.espresso.matcher.ViewMatchers.withId;
import static androidx.test.espresso.matcher.ViewMatchers.withText; import static androidx.test.espresso.matcher.ViewMatchers.withText;
import android.os.Build;
import android.support.test.InstrumentationRegistry; import android.support.test.InstrumentationRegistry;
import android.support.test.uiautomator.UiDevice; import android.support.test.uiautomator.UiDevice;
...@@ -32,7 +31,6 @@ import org.chromium.base.test.params.ParameterProvider; ...@@ -32,7 +31,6 @@ import org.chromium.base.test.params.ParameterProvider;
import org.chromium.base.test.params.ParameterSet; import org.chromium.base.test.params.ParameterSet;
import org.chromium.base.test.params.ParameterizedRunner; import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.app.ChromeActivity; import org.chromium.chrome.browser.app.ChromeActivity;
...@@ -49,7 +47,6 @@ import org.chromium.net.test.ServerCertificate; ...@@ -49,7 +47,6 @@ import org.chromium.net.test.ServerCertificate;
import org.chromium.ui.test.util.DisableAnimationsTestRule; import org.chromium.ui.test.util.DisableAnimationsTestRule;
import org.chromium.url.GURL; import org.chromium.url.GURL;
import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
...@@ -112,19 +109,15 @@ public class ExpandablePaymentHandlerTest { ...@@ -112,19 +109,15 @@ public class ExpandablePaymentHandlerTest {
public static class GoodCertParams implements ParameterProvider { public static class GoodCertParams implements ParameterProvider {
@Override @Override
public List<ParameterSet> getParameters() { public List<ParameterSet> getParameters() {
List<ParameterSet> parameters = new ArrayList<>(); return Arrays.asList(
parameters.add(new ParameterSet() new ParameterSet().value(ServerCertificate.CERT_OK).name("CERT_OK"),
.value(ServerCertificate.CERT_COMMON_NAME_IS_DOMAIN) new ParameterSet()
.name("CERT_COMMON_NAME_IS_DOMAIN")); .value(ServerCertificate.CERT_COMMON_NAME_IS_DOMAIN)
parameters.add(new ParameterSet().value(ServerCertificate.CERT_AUTO).name("CERT_AUTO")); .name("CERT_COMMON_NAME_IS_DOMAIN"),
// Disabling 2 parameterized tests on M per https://crbug.com/1101030 new ParameterSet()
if (Build.VERSION.SDK_INT != Build.VERSION_CODES.M) { .value(ServerCertificate.CERT_OK_BY_INTERMEDIATE)
parameters.add(new ParameterSet().value(ServerCertificate.CERT_OK).name("CERT_OK")); .name("CERT_OK_BY_INTERMEDIATE"),
parameters.add(new ParameterSet() new ParameterSet().value(ServerCertificate.CERT_AUTO).name("CERT_AUTO"));
.value(ServerCertificate.CERT_OK_BY_INTERMEDIATE)
.name("CERT_OK_BY_INTERMEDIATE"));
}
return parameters;
} }
} }
...@@ -365,12 +358,8 @@ public class ExpandablePaymentHandlerTest { ...@@ -365,12 +358,8 @@ public class ExpandablePaymentHandlerTest {
@Test @Test
@SmallTest @SmallTest
@DisableIf.Build(message = "https://crbug.com/1101030",
sdk_is_greater_than = Build.VERSION_CODES.LOLLIPOP_MR1,
sdk_is_less_than = Build.VERSION_CODES.N)
@Feature({"Payments"}) @Feature({"Payments"})
public void public void testNavigateBackWithSystemBackButton() throws Throwable {
testNavigateBackWithSystemBackButton() throws Throwable {
startDefaultServer(); startDefaultServer();
PaymentHandlerCoordinator paymentHandler = createPaymentHandlerAndShow(mDefaultIsIncognito); PaymentHandlerCoordinator paymentHandler = createPaymentHandlerAndShow(mDefaultIsIncognito);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment