Commit c5fb1770 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[USS] Rename the SharedModelTypeProcessor

This is a follow up CL to
https://chromium-review.googlesource.com/c/chromium/src/+/951245

That renames couple of other occurrences of SharedModelTypeProcessor

Change-Id: I55657cc2b0e98c8a0b7dacf2c4be97ee770f51ef
Reviewed-on: https://chromium-review.googlesource.com/953542Reviewed-by: default avatarJan Krcal <jkrcal@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541758}
parent d1471ff1
...@@ -95,8 +95,9 @@ class ModelTypeController : public DataTypeController { ...@@ -95,8 +95,9 @@ class ModelTypeController : public DataTypeController {
// Callbacks for use when starting the datatype. // Callbacks for use when starting the datatype.
ModelLoadCallback model_load_callback_; ModelLoadCallback model_load_callback_;
// Controller receives |activation_context_| from SharedModelTypeProcessor // Controller receives |activation_context_| from
// callback and must temporarily own it until ActivateDataType is called. // ClientTagBasedModelTypeProcessor callback and must temporarily own it until
// ActivateDataType is called.
std::unique_ptr<ActivationContext> activation_context_; std::unique_ptr<ActivationContext> activation_context_;
// This is a hack to prevent reconfigurations from crashing, because USS // This is a hack to prevent reconfigurations from crashing, because USS
......
...@@ -15,7 +15,7 @@ NonBlockingTypeDebugInfoEmitter::~NonBlockingTypeDebugInfoEmitter() {} ...@@ -15,7 +15,7 @@ NonBlockingTypeDebugInfoEmitter::~NonBlockingTypeDebugInfoEmitter() {}
void NonBlockingTypeDebugInfoEmitter::EmitStatusCountersUpdate() { void NonBlockingTypeDebugInfoEmitter::EmitStatusCountersUpdate() {
// TODO(gangwu): Allow driving emission of status counters from here. This is // TODO(gangwu): Allow driving emission of status counters from here. This is
// tricky because we do not have access to SharedModelTypeProcessor or // tricky because we do not have access to ClientTagBasedModelTypeProcessor or
// ModelTypeStore currently. This method is fairly redundant since counters // ModelTypeStore currently. This method is fairly redundant since counters
// are also emitted from the UI thread, unclear how important this is. // are also emitted from the UI thread, unclear how important this is.
} }
......
...@@ -19,9 +19,9 @@ struct CommitRequestData; ...@@ -19,9 +19,9 @@ struct CommitRequestData;
struct CommitResponseData; struct CommitResponseData;
struct UpdateResponseData; struct UpdateResponseData;
// This class is used by the SharedModelTypeProcessor to track the state of each // This class is used by the ClientTagBasedModelTypeProcessor to track the state
// entity with its type. It can be considered a helper class internal to the // of each entity with its type. It can be considered a helper class internal to
// processor. It manages the metadata for its entity and caches entity data // the processor. It manages the metadata for its entity and caches entity data
// upon a local change until commit confirmation is received. // upon a local change until commit confirmation is received.
class ProcessorEntityTracker { class ProcessorEntityTracker {
public: public:
......
...@@ -92,12 +92,13 @@ CommitResponseData GenerateAckData(const CommitRequestData& request, ...@@ -92,12 +92,13 @@ CommitResponseData GenerateAckData(const CommitRequestData& request,
// Some simple sanity tests for the ProcessorEntityTracker. // Some simple sanity tests for the ProcessorEntityTracker.
// //
// A lot of the more complicated sync logic is implemented in the // A lot of the more complicated sync logic is implemented in the
// SharedModelTypeProcessor that owns the ProcessorEntityTracker. We can't unit // ClientTagBasedModelTypeProcessor that owns the ProcessorEntityTracker. We
// test it here. // can't unit test it here.
// //
// Instead, we focus on simple tests to make sure that variables are getting // Instead, we focus on simple tests to make sure that variables are getting
// properly intialized and flags properly set. Anything more complicated would // properly intialized and flags properly set. Anything more complicated would
// be a redundant and incomplete version of the SharedModelTypeProcessor tests. // be a redundant and incomplete version of the ClientTagBasedModelTypeProcessor
// tests.
class ProcessorEntityTrackerTest : public ::testing::Test { class ProcessorEntityTrackerTest : public ::testing::Test {
public: public:
ProcessorEntityTrackerTest() ProcessorEntityTrackerTest()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment