Commit c6221aaa authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

bindings: Do not refer partial interfaces' constructors

Partial interfaces do not have constructors, so we can't nominate
them as members of V8ContextSnapshotExternalReferences.


Bug: 806163
Change-Id: I28e20fac326d57851f6443cca7c0c53bc86680fb
Reviewed-on: https://chromium-review.googlesource.com/888181Reviewed-by: default avatarKenichi Ishibashi <bashi@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532081}
parent 32ce3342
......@@ -74,10 +74,12 @@ class InterfaceTemplateContextBuilder(object):
name = '%s%s' % (v8_utilities.cpp_name(interface), 'Partial' if interface.is_partial else '')
# Constructors
constructors = any(constructor.name == 'Constructor' for constructor in interface.constructors)
custom_constructors = interface.custom_constructors
html_constructor = 'HTMLConstructor' in interface.extended_attributes
has_constructor_callback = constructors or custom_constructors or html_constructor
has_constructor_callback = False
if not interface.is_partial:
constructors = any(constructor.name == 'Constructor' for constructor in interface.constructors)
custom_constructors = interface.custom_constructors
html_constructor = 'HTMLConstructor' in interface.extended_attributes
has_constructor_callback = constructors or custom_constructors or html_constructor
attributes = []
methods = []
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment