Commit c6259cb5 authored by Lily Chen's avatar Lily Chen Committed by Chromium LUCI CQ

Remove Cookie.SameSiteUnspecifiedEffective histogram

This histogram was about to expire, and is no longer interesting as
SameSite-by-default has launched which makes the samples almost entirely
Lax.

Bug: 1165039
Change-Id: I19bdb1ed423e198e7ffc22b2d24cfef81d6b9764
Fixed: 1165039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623001Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843006}
parent fc7a4b3b
...@@ -713,13 +713,6 @@ CookieAccessResult CanonicalCookie::IncludeForRequestURL( ...@@ -713,13 +713,6 @@ CookieAccessResult CanonicalCookie::IncludeForRequestURL(
CookieEffectiveSameSite effective_same_site = CookieEffectiveSameSite effective_same_site =
GetEffectiveSameSite(params.access_semantics); GetEffectiveSameSite(params.access_semantics);
DCHECK(effective_same_site != CookieEffectiveSameSite::UNDEFINED); DCHECK(effective_same_site != CookieEffectiveSameSite::UNDEFINED);
// Log the effective SameSite mode that is applied to the cookie on this
// request, if its SameSite was not specified.
if (SameSite() == CookieSameSite::UNSPECIFIED) {
UMA_HISTOGRAM_ENUMERATION("Cookie.SameSiteUnspecifiedEffective",
effective_same_site,
CookieEffectiveSameSite::COUNT);
}
UMA_HISTOGRAM_ENUMERATION( UMA_HISTOGRAM_ENUMERATION(
"Cookie.RequestSameSiteContext", cookie_inclusion_context, "Cookie.RequestSameSiteContext", cookie_inclusion_context,
CookieOptions::SameSiteCookieContext::ContextType::COUNT); CookieOptions::SameSiteCookieContext::ContextType::COUNT);
......
...@@ -540,6 +540,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -540,6 +540,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Cookie.SameSiteUnspecifiedEffective" <histogram name="Cookie.SameSiteUnspecifiedEffective"
enum="CookieEffectiveSameSite" expires_after="M90"> enum="CookieEffectiveSameSite" expires_after="M90">
<obsolete>
Removed Jan 2021 for cleanup: crbug.com/1165039
</obsolete>
<owner>chlily@chromium.org</owner> <owner>chlily@chromium.org</owner>
<owner>morlovich@chromium.org</owner> <owner>morlovich@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment