[iOS][MF] Add support for device rotation

Adds a flag wich resets after a delay when the device rotates. This
allows to know if certain notification are caused due a recent rotation.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7b36544a451c677ff0ff842876f80841847a2833
Reviewed-on: https://chromium-review.googlesource.com/c/1273145
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601072}

ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_helper.mm

@@ -10,8 +10,15 @@
 
 @interface KeyboardObserverHelper ()
 
-// Boolean to check if the keyboard was actually dismissed.
-@property(nonatomic) BOOL keyboardOnScreen;
+// Flag that indicates if the keyboard is on screen.
+@property(nonatomic, getter=isKeyboardOnScreen) BOOL keyboardOnScreen;
+
+// Flag that indicates if the next keyboard did hide notification should be
+// ignored. This happens when the keyboard is on screen and the device rotates.
+// Causing keyboard notifications to be sent, but the keyboard never leaves the
+// screen.
+@property(nonatomic, getter=shouldIgnoreNextKeyboardDidHide)
+    BOOL ignoreNextKeyboardDidHide;
 
 @end
 
@@ -35,6 +42,11 @@
            selector:@selector(keyboardDidHide:)
                name:UIKeyboardDidHideNotification
              object:nil];
+    [[NSNotificationCenter defaultCenter]
+        addObserver:self
+           selector:@selector(orientationDidChange:)
+               name:UIApplicationDidChangeStatusBarOrientationNotification
+             object:nil];
   }
   return self;
 }
@@ -53,6 +65,12 @@
 }
 
 - (void)keyboardDidHide:(NSNotification*)notification {
+  // If UIKeyboardDidHideNotification was sent because of a orientation
+  // change, reset the flag and ignore.
+  if (self.shouldIgnoreNextKeyboardDidHide) {
+    self.ignoreNextKeyboardDidHide = NO;
+    return;
+  }
   dispatch_async(dispatch_get_main_queue(), ^{
     if (!self.keyboardOnScreen) {
       [self.delegate keyboardDidHide];
@@ -60,4 +78,12 @@
   });
 }
 
+- (void)orientationDidChange:(NSNotification*)notification {
+  // If the keyboard is on screen, set the flag to ignore next keyboard did
+  // hide.
+  if (self.keyboardOnScreen) {
+    self.ignoreNextKeyboardDidHide = YES;
+  }
+}
+
 @end

ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm

@@ -224,6 +224,8 @@ void ClearPasswordStore() {
 
 - (void)tearDown {
   ClearPasswordStore();
+  [EarlGrey rotateDeviceToOrientation:UIDeviceOrientationPortrait
+                           errorOrNil:nil];
   [super tearDown];
 }
 
@@ -501,4 +503,26 @@ void ClearPasswordStore() {
       assertWithMatcher:grey_sufficientlyVisible()];
 }
 
+// Test that the Password View Controller stays on rotation.
+- (void)testPasswordControllerSupportsRotation {
+  // Bring up the keyboard.
+  [[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
+      performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
+
+  // Tap on the passwords icon.
+  [[EarlGrey selectElementWithMatcher:PasswordIconMatcher()]
+      performAction:grey_tap()];
+
+  // Verify the password controller table view is visible.
+  [[EarlGrey selectElementWithMatcher:PasswordTableViewMatcher()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+
+  [EarlGrey rotateDeviceToOrientation:UIDeviceOrientationLandscapeLeft
+                           errorOrNil:nil];
+
+  // Verify the password controller table view is still visible.
+  [[EarlGrey selectElementWithMatcher:PasswordTableViewMatcher()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
 @end