Commit c62c866d authored by Daniel Cheng's avatar Daniel Cheng Committed by Chromium LUCI CQ

Use TraceWrapperV8Reference to hold ExceptionState::exception_.

On-stack tracing of TraceWrapperV8Reference Just Works.

Bug: 1013149
Change-Id: I8c403cd4b9c86adb344fefbf32602d87d39eceb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625372Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843139}
parent 98cc84e7
...@@ -34,7 +34,7 @@ ...@@ -34,7 +34,7 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/notreached.h" #include "base/notreached.h"
#include "third_party/blink/renderer/platform/bindings/exception_code.h" #include "third_party/blink/renderer/platform/bindings/exception_code.h"
#include "third_party/blink/renderer/platform/bindings/scoped_persistent.h" #include "third_party/blink/renderer/platform/bindings/trace_wrapper_v8_reference.h"
#include "third_party/blink/renderer/platform/bindings/v8_throw_exception.h" #include "third_party/blink/renderer/platform/bindings/v8_throw_exception.h"
#include "third_party/blink/renderer/platform/platform_export.h" #include "third_party/blink/renderer/platform/platform_export.h"
#include "third_party/blink/renderer/platform/wtf/allocator/allocator.h" #include "third_party/blink/renderer/platform/wtf/allocator/allocator.h"
...@@ -190,7 +190,7 @@ class PLATFORM_EXPORT ExceptionState { ...@@ -190,7 +190,7 @@ class PLATFORM_EXPORT ExceptionState {
const char* interface_name_; const char* interface_name_;
// The exception is empty when it was thrown through // The exception is empty when it was thrown through
// DummyExceptionStateForTesting. // DummyExceptionStateForTesting.
ScopedPersistent<v8::Value> exception_; TraceWrapperV8Reference<v8::Value> exception_;
v8::Isolate* isolate_; v8::Isolate* isolate_;
DISALLOW_COPY_AND_ASSIGN(ExceptionState); DISALLOW_COPY_AND_ASSIGN(ExceptionState);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment