Commit c64c683e authored by Theresa Wellington's avatar Theresa Wellington Committed by Commit Bot

[Home] Show toast when suggestions content opened in the background

Bug: 725015

Change-Id: I54b72b7dd0506aa64521aa43d6bd6614376b6437
Reviewed-on: https://chromium-review.googlesource.com/562538Reviewed-by: default avatarNicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484991}
parent 6bee55cd
...@@ -7,10 +7,12 @@ package org.chromium.chrome.browser.suggestions; ...@@ -7,10 +7,12 @@ package org.chromium.chrome.browser.suggestions;
import android.support.annotation.Nullable; import android.support.annotation.Nullable;
import org.chromium.base.metrics.RecordUserAction; import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.NativePageHost; import org.chromium.chrome.browser.NativePageHost;
import org.chromium.chrome.browser.UrlConstants; import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.bookmarks.BookmarkUtils; import org.chromium.chrome.browser.bookmarks.BookmarkUtils;
import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.download.DownloadUtils; import org.chromium.chrome.browser.download.DownloadUtils;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils; import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.ntp.NewTabPageUma; import org.chromium.chrome.browser.ntp.NewTabPageUma;
...@@ -31,6 +33,7 @@ import org.chromium.content_public.browser.LoadUrlParams; ...@@ -31,6 +33,7 @@ import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.common.Referrer; import org.chromium.content_public.common.Referrer;
import org.chromium.ui.base.PageTransition; import org.chromium.ui.base.PageTransition;
import org.chromium.ui.mojom.WindowOpenDisposition; import org.chromium.ui.mojom.WindowOpenDisposition;
import org.chromium.ui.widget.Toast;
/** /**
* {@link SuggestionsUiDelegate} implementation. * {@link SuggestionsUiDelegate} implementation.
...@@ -184,8 +187,21 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD ...@@ -184,8 +187,21 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD
} }
private Tab openUrlInNewTab(LoadUrlParams loadUrlParams) { private Tab openUrlInNewTab(LoadUrlParams loadUrlParams) {
return mTabModelSelector.openNewTab(loadUrlParams, TabLaunchType.FROM_LONGPRESS_BACKGROUND, Tab tab = mTabModelSelector.openNewTab(loadUrlParams,
mHost.getActiveTab(), /* incognito = */ false); TabLaunchType.FROM_LONGPRESS_BACKGROUND, mHost.getActiveTab(),
/* incognito = */ false);
// If the bottom sheet NTP UI is showing, a toast is not necessary because the bottom sheet
// will be closed when the overview is hidden due to the new tab creation above.
// If animations are disabled in the DeviceClassManager, a toast is already displayed for
// all tabs opened in the background.
// TODO(twellington): Replace this with an animation.
if (mActivity.getBottomSheet() != null && !mActivity.getBottomSheet().isShowingNewTab()
&& DeviceClassManager.enableAnimations()) {
Toast.makeText(mActivity, R.string.open_in_new_tab_toast, Toast.LENGTH_SHORT).show();
}
return tab;
} }
private void saveUrlForOffline(String url) { private void saveUrlForOffline(String url) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment