Skip to content

GitLab

T
tangled
Commit c677ff37 authored by Hajime Hoshi's avatar Hajime Hoshi Committed by Commit Bot
Browse files
Options

Revert "Ensure consistent focus status of some form tests" 

This reverts commit 16980f14.

Reason for revert: test failures: crbug.com/1017573

Original change's description:
> Ensure consistent focus status of some form tests
> 
> The tests were flaky because of inconsistent forcus status.
> 
> Change-Id: Idb494efcc489a441446c4a9b12968cde86faf8e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872991
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708675}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: I04e8ff32caf0719c12552f51d6611b7e41fb4598
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877871Reviewed-by: default avatarHajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708909}
parent 32464c1b
Hide whitespace changes
Inline Side-by-side
Showing with 23 additions and 8 deletions
third_party/blink/web_tests/TestExpectations
View file @ c677ff37
......@@ -5688,6 +5688,11 @@ crbug.com/1013523 [ Release ] virtual/cross-origin-embedder-policy/external/wpt/
crbug.com/1013523 [ Release Linux Mac ] external/wpt/html/cross-origin-embedder-policy/require-corp.https.html [ Failure Pass ]
crbug.com/1010472 [ Linux Mac Debug ] virtual/disable-deferred-rendering/fast/canvas/color-space/canvas-drawImage-offscreenCanvas.html [ Timeout Pass ]
crbug.com/1010472 [ Mac Debug ] virtual/disable-deferred-rendering/fast/canvas/OffscreenCanvas-placeholder-createImageBitmap.html [ Failure Pass ]
crbug.com/1013779 virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance.html [ Failure Pass ]
crbug.com/1013779 [ Mac ] virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance.html [ Failure Pass ]
crbug.com/1013779 virtual/scalefactor200/fast/hidpi/static/pointerevents/pointerevent_touch-adjustment_click_target.html [ Failure Pass ]
crbug.com/1013779 virtual/scalefactor200/fast/hidpi/static/popup-menu-appearance.html [ Failure Pass ]
crbug.com/1013779 virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html [ Failure Pass ]
crbug.com/990900 external/wpt/cookie-store/idlharness.tentative.https.any.serviceworker.html [ Pass Timeout ]
crbug.com/990900 virtual/omt-worker-fetch/external/wpt/fetch/api/idlharness.any.html [ Pass Timeout ]
......
third_party/blink/web_tests/compositing/overflow/resources/update-widget-positions-on-nested-frames-and-scrollers-inner-frame.html
View file @ c677ff37
......@@ -17,7 +17,10 @@
return;
var select = document.getElementById('select');
openPicker(select, callback, function () {
// FIXME: it would be really nice to use getBoundingClientRect() and not
// hard-code pixel coordinates here, but since it's in an iframe, the
// coordinates are translated anyway.
clickToOpenPicker(50, 120, callback, function () {
setTimeout(callback, 0);
});
}
......@@ -44,7 +47,7 @@
select.appendChild(option);
}
if (x == 23) {
if (x == 24) {
select.id = 'select';
}
......
third_party/blink/web_tests/fast/forms/resources/picker-common.js
View file @ c677ff37
......@@ -45,8 +45,17 @@ function openPicker(element, callback, errorCallback) {
eventSender.keyDown("ArrowDown", ["altKey"]);
}
}
// To avoid flakiness of test about focused status of the element.
element.focus();
popupWindow = internals.pagePopupWindow;
if (typeof callback === "function" && popupWindow)
setPopupOpenCallback(callback);
else if (typeof errorCallback === "function" && !popupWindow)
errorCallback();
}
function clickToOpenPicker(x, y, callback, errorCallback) {
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
eventSender.mouseUp();
popupWindow = internals.pagePopupWindow;
if (typeof callback === "function" && popupWindow)
setPopupOpenCallback(callback);
......
third_party/blink/web_tests/fast/hidpi/static/validation-bubble-appearance-hidpi.html
View file @ c677ff37
......@@ -2,12 +2,10 @@
<body>
<div style="width:100%; height:4em; overflow:scroll">
<div style="position:relative; left:90%; top:1000px; width:100%; font-family:system-ui; font-size:16px">
Font-size in the validation bubble should be same as this paragraph.<input id=checkbox type=checkbox required>
Font-size in the validation bubble should be same as this paragraph.<input type=checkbox required>
</div>
</div>
<script>
checkbox.reportValidity();
// To avoid flakiness of test about focused status of the element.
checkbox.focus();
document.querySelector('input').reportValidity();
</script>
</body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment