Commit c68731aa authored by Alexandre Frechette's avatar Alexandre Frechette Committed by Commit Bot

Removing TranslateManualTrigger feature.

Change-Id: I2af8368c4c85990b0a72407ef8be7233f26ddfb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754105
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Reviewed-by: default avatarPeter Lee <pkl@chromium.org>
Reviewed-by: default avataranthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695292}
parent b5e2f020
...@@ -3678,10 +3678,6 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -3678,10 +3678,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kDrawVerticallyEdgeToEdgeName, flag_descriptions::kDrawVerticallyEdgeToEdgeName,
flag_descriptions::kDrawVerticallyEdgeToEdgeDescription, kOsAndroid, flag_descriptions::kDrawVerticallyEdgeToEdgeDescription, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kDrawVerticallyEdgeToEdge)}, FEATURE_VALUE_TYPE(chrome::android::kDrawVerticallyEdgeToEdge)},
{"translate-android-manual-trigger",
flag_descriptions::kTranslateAndroidManualTriggerName,
flag_descriptions::kTranslateAndroidManualTriggerDescription, kOsAndroid,
FEATURE_VALUE_TYPE(translate::kTranslateMobileManualTrigger)},
#endif #endif
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
{"enable-ephemeral-tab", flag_descriptions::kEphemeralTabName, {"enable-ephemeral-tab", flag_descriptions::kEphemeralTabName,
......
...@@ -2701,11 +2701,6 @@ extern const char kTabSwitcherLongpressMenuDescription[] = ...@@ -2701,11 +2701,6 @@ extern const char kTabSwitcherLongpressMenuDescription[] =
"Enable showing a popup menu when the tab switcher is long-pressed, which " "Enable showing a popup menu when the tab switcher is long-pressed, which "
"displays options for 'NewTab', 'New incognito tab' and 'Close tab'."; "displays options for 'NewTab', 'New incognito tab' and 'Close tab'.";
const char kTranslateAndroidManualTriggerName[] =
"Enable manual translate trigger";
const char kTranslateAndroidManualTriggerDescription[] =
"Show a menu item in the main menu that triggers page translation.";
const char kStartSurfaceAndroidName[] = "Start Surface"; const char kStartSurfaceAndroidName[] = "Start Surface";
const char kStartSurfaceAndroidDescription[] = const char kStartSurfaceAndroidDescription[] =
"Enable showing the start surface when launching Chrome via the " "Enable showing the start surface when launching Chrome via the "
......
...@@ -1588,9 +1588,6 @@ extern const char kStrictSiteIsolationDescription[]; ...@@ -1588,9 +1588,6 @@ extern const char kStrictSiteIsolationDescription[];
extern const char kTabSwitcherLongpressMenuName[]; extern const char kTabSwitcherLongpressMenuName[];
extern const char kTabSwitcherLongpressMenuDescription[]; extern const char kTabSwitcherLongpressMenuDescription[];
extern const char kTranslateAndroidManualTriggerName[];
extern const char kTranslateAndroidManualTriggerDescription[];
extern const char kStartSurfaceAndroidName[]; extern const char kStartSurfaceAndroidName[];
extern const char kStartSurfaceAndroidDescription[]; extern const char kStartSurfaceAndroidDescription[];
......
...@@ -82,9 +82,6 @@ const base::Feature kTranslateRecentTarget{"TranslateRecentTarget", ...@@ -82,9 +82,6 @@ const base::Feature kTranslateRecentTarget{"TranslateRecentTarget",
const base::Feature kTranslateUI{"TranslateUI", const base::Feature kTranslateUI{"TranslateUI",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kTranslateMobileManualTrigger{
"TranslateAndroidManualTrigger", base::FEATURE_ENABLED_BY_DEFAULT};
DenialTimeUpdate::DenialTimeUpdate(PrefService* prefs, DenialTimeUpdate::DenialTimeUpdate(PrefService* prefs,
const std::string& language, const std::string& language,
size_t max_denial_count) size_t max_denial_count)
......
...@@ -43,9 +43,6 @@ extern const base::Feature kTranslateRecentTarget; ...@@ -43,9 +43,6 @@ extern const base::Feature kTranslateRecentTarget;
// Enable or disable the Translate popup altogether. // Enable or disable the Translate popup altogether.
extern const base::Feature kTranslateUI; extern const base::Feature kTranslateUI;
// Enable the "Translate" item in the overflow menu on Mobile.
extern const base::Feature kTranslateMobileManualTrigger;
// Minimum number of times the user must accept a translation before we show // Minimum number of times the user must accept a translation before we show
// a shortcut to the "Always Translate" functionality. // a shortcut to the "Always Translate" functionality.
#if defined(OS_ANDROID) || defined(OS_IOS) #if defined(OS_ANDROID) || defined(OS_IOS)
......
...@@ -3325,21 +3325,6 @@ ...@@ -3325,21 +3325,6 @@
] ]
} }
], ],
"ManualTranslateTrigger": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"TranslateAndroidManualTrigger"
]
}
]
}
],
"MediaCapabilitiesWithParameters": [ "MediaCapabilitiesWithParameters": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment