Commit c6a96ae8 authored by Michael Thiessen's avatar Michael Thiessen Committed by Commit Bot

Add debug logging to WebApk network errors.

Touchless tests are hitting network errors inexplicably on bots, and I'm
unable to repro locally, so I'm adding logging to hopefully get more
insight.

Bug: 983769
Change-Id: If9ed3b7569c1d26a7923bac5f458a44fb4edb331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741291Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685195}
parent 5f529dbc
...@@ -8,6 +8,7 @@ import android.app.Activity; ...@@ -8,6 +8,7 @@ import android.app.Activity;
import android.content.Context; import android.content.Context;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.metrics.WebApkUma; import org.chromium.chrome.browser.metrics.WebApkUma;
import org.chromium.chrome.browser.tab.EmptyTabObserver; import org.chromium.chrome.browser.tab.EmptyTabObserver;
...@@ -21,6 +22,7 @@ import org.chromium.net.NetworkChangeNotifier; ...@@ -21,6 +22,7 @@ import org.chromium.net.NetworkChangeNotifier;
* start URL. * start URL.
*/ */
public class WebApkSplashNetworkErrorObserver extends EmptyTabObserver { public class WebApkSplashNetworkErrorObserver extends EmptyTabObserver {
private static final String TAG = "WebApkSplashNetObs";
private Activity mActivity; private Activity mActivity;
private WebApkOfflineDialog mOfflineDialog; private WebApkOfflineDialog mOfflineDialog;
private String mWebApkName; private String mWebApkName;
...@@ -54,6 +56,11 @@ public class WebApkSplashNetworkErrorObserver extends EmptyTabObserver { ...@@ -54,6 +56,11 @@ public class WebApkSplashNetworkErrorObserver extends EmptyTabObserver {
onNetworkChanged(tab); onNetworkChanged(tab);
break; break;
default: default:
// TODO(mthiesse): These logs are for debugging https://crbug.com/983769 and should
// be removed once that's resolved.
Log.d(TAG,
"Network error loading WebApk at URL: " + navigation.getUrl()
+ ", with error: " + navigation.errorCode());
onNetworkError(tab, navigation.errorCode()); onNetworkError(tab, navigation.errorCode());
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment