Commit c6ca9904 authored by Zhongyi Shi's avatar Zhongyi Shi Committed by Commit Bot

[Cronet Android] Do not skip API presubmit checks on Experimental classes.

Those experimental APIs are consumed by some customers, and needs to be supported indefinitely. Add those APIs to presubmit checklist will help ensure those APIs are never modified or removed.

Change-Id: I057fff4cfe30f08f020717f263f7050be399a000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974701Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Reviewed-by: default avatarMisha Efimov <mef@chromium.org>
Reviewed-by: default avatarPaul Jensen <pauljensen@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726438}
parent 33132ec8
...@@ -95,6 +95,106 @@ public abstract class org.chromium.net.CronetProvider { ...@@ -95,6 +95,106 @@ public abstract class org.chromium.net.CronetProvider {
public java.lang.String toString(); public java.lang.String toString();
public static java.util.List<org.chromium.net.CronetProvider> getAllProviders(android.content.Context); public static java.util.List<org.chromium.net.CronetProvider> getAllProviders(android.content.Context);
} }
public abstract class org.chromium.net.ExperimentalBidirectionalStream$Builder extends org.chromium.net.BidirectionalStream$Builder {
public org.chromium.net.ExperimentalBidirectionalStream$Builder();
public org.chromium.net.ExperimentalBidirectionalStream$Builder addRequestAnnotation(java.lang.Object);
public org.chromium.net.ExperimentalBidirectionalStream$Builder setTrafficStatsTag(int);
public org.chromium.net.ExperimentalBidirectionalStream$Builder setTrafficStatsUid(int);
public abstract org.chromium.net.ExperimentalBidirectionalStream$Builder setHttpMethod(java.lang.String);
public abstract org.chromium.net.ExperimentalBidirectionalStream$Builder addHeader(java.lang.String, java.lang.String);
public abstract org.chromium.net.ExperimentalBidirectionalStream$Builder setPriority(int);
public abstract org.chromium.net.ExperimentalBidirectionalStream$Builder delayRequestHeadersUntilFirstFlush(boolean);
public abstract org.chromium.net.ExperimentalBidirectionalStream build();
public org.chromium.net.BidirectionalStream build();
public org.chromium.net.BidirectionalStream$Builder delayRequestHeadersUntilFirstFlush(boolean);
public org.chromium.net.BidirectionalStream$Builder setPriority(int);
public org.chromium.net.BidirectionalStream$Builder addHeader(java.lang.String, java.lang.String);
public org.chromium.net.BidirectionalStream$Builder setHttpMethod(java.lang.String);
}
public abstract class org.chromium.net.ExperimentalBidirectionalStream extends org.chromium.net.BidirectionalStream {
public org.chromium.net.ExperimentalBidirectionalStream();
}
public class org.chromium.net.ExperimentalCronetEngine$Builder extends org.chromium.net.CronetEngine$Builder {
public org.chromium.net.ExperimentalCronetEngine$Builder(android.content.Context);
public org.chromium.net.ExperimentalCronetEngine$Builder(org.chromium.net.ICronetEngineBuilder);
public org.chromium.net.ExperimentalCronetEngine$Builder enableNetworkQualityEstimator(boolean);
public org.chromium.net.ExperimentalCronetEngine$Builder setExperimentalOptions(java.lang.String);
public org.chromium.net.ExperimentalCronetEngine$Builder setThreadPriority(int);
public org.chromium.net.ICronetEngineBuilder getBuilderDelegate();
public org.chromium.net.ExperimentalCronetEngine$Builder setUserAgent(java.lang.String);
public org.chromium.net.ExperimentalCronetEngine$Builder setStoragePath(java.lang.String);
public org.chromium.net.ExperimentalCronetEngine$Builder setLibraryLoader(org.chromium.net.CronetEngine$Builder$LibraryLoader);
public org.chromium.net.ExperimentalCronetEngine$Builder enableQuic(boolean);
public org.chromium.net.ExperimentalCronetEngine$Builder enableHttp2(boolean);
public org.chromium.net.ExperimentalCronetEngine$Builder enableSdch(boolean);
public org.chromium.net.ExperimentalCronetEngine$Builder enableHttpCache(int, long);
public org.chromium.net.ExperimentalCronetEngine$Builder addQuicHint(java.lang.String, int, int);
public org.chromium.net.ExperimentalCronetEngine$Builder addPublicKeyPins(java.lang.String, java.util.Set<byte[]>, boolean, java.util.Date);
public org.chromium.net.ExperimentalCronetEngine$Builder enablePublicKeyPinningBypassForLocalTrustAnchors(boolean);
public org.chromium.net.ExperimentalCronetEngine build();
public org.chromium.net.CronetEngine build();
public org.chromium.net.CronetEngine$Builder enablePublicKeyPinningBypassForLocalTrustAnchors(boolean);
public org.chromium.net.CronetEngine$Builder addPublicKeyPins(java.lang.String, java.util.Set, boolean, java.util.Date);
public org.chromium.net.CronetEngine$Builder addQuicHint(java.lang.String, int, int);
public org.chromium.net.CronetEngine$Builder enableHttpCache(int, long);
public org.chromium.net.CronetEngine$Builder enableSdch(boolean);
public org.chromium.net.CronetEngine$Builder enableHttp2(boolean);
public org.chromium.net.CronetEngine$Builder enableQuic(boolean);
public org.chromium.net.CronetEngine$Builder setLibraryLoader(org.chromium.net.CronetEngine$Builder$LibraryLoader);
public org.chromium.net.CronetEngine$Builder setStoragePath(java.lang.String);
public org.chromium.net.CronetEngine$Builder setUserAgent(java.lang.String);
}
public abstract class org.chromium.net.ExperimentalCronetEngine extends org.chromium.net.CronetEngine {
public static final int CONNECTION_METRIC_UNKNOWN;
public static final int EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
public static final int EFFECTIVE_CONNECTION_TYPE_OFFLINE;
public static final int EFFECTIVE_CONNECTION_TYPE_SLOW_2G;
public static final int EFFECTIVE_CONNECTION_TYPE_2G;
public static final int EFFECTIVE_CONNECTION_TYPE_3G;
public static final int EFFECTIVE_CONNECTION_TYPE_4G;
public org.chromium.net.ExperimentalCronetEngine();
public abstract org.chromium.net.ExperimentalBidirectionalStream$Builder newBidirectionalStreamBuilder(java.lang.String, org.chromium.net.BidirectionalStream$Callback, java.util.concurrent.Executor);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder newUrlRequestBuilder(java.lang.String, org.chromium.net.UrlRequest$Callback, java.util.concurrent.Executor);
public void startNetLogToDisk(java.lang.String, boolean, int);
public int getEffectiveConnectionType();
public void configureNetworkQualityEstimatorForTesting(boolean, boolean, boolean);
public void addRttListener(org.chromium.net.NetworkQualityRttListener);
public void removeRttListener(org.chromium.net.NetworkQualityRttListener);
public void addThroughputListener(org.chromium.net.NetworkQualityThroughputListener);
public void removeThroughputListener(org.chromium.net.NetworkQualityThroughputListener);
public java.net.URLConnection openConnection(java.net.URL, java.net.Proxy) throws java.io.IOException;
public void addRequestFinishedListener(org.chromium.net.RequestFinishedInfo$Listener);
public void removeRequestFinishedListener(org.chromium.net.RequestFinishedInfo$Listener);
public int getHttpRttMs();
public int getTransportRttMs();
public int getDownstreamThroughputKbps();
public org.chromium.net.UrlRequest$Builder newUrlRequestBuilder(java.lang.String, org.chromium.net.UrlRequest$Callback, java.util.concurrent.Executor);
}
public abstract class org.chromium.net.ExperimentalUrlRequest$Builder extends org.chromium.net.UrlRequest$Builder {
public org.chromium.net.ExperimentalUrlRequest$Builder();
public org.chromium.net.ExperimentalUrlRequest$Builder disableConnectionMigration();
public org.chromium.net.ExperimentalUrlRequest$Builder addRequestAnnotation(java.lang.Object);
public org.chromium.net.ExperimentalUrlRequest$Builder setTrafficStatsTag(int);
public org.chromium.net.ExperimentalUrlRequest$Builder setTrafficStatsUid(int);
public org.chromium.net.ExperimentalUrlRequest$Builder setRequestFinishedListener(org.chromium.net.RequestFinishedInfo$Listener);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder setHttpMethod(java.lang.String);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder addHeader(java.lang.String, java.lang.String);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder disableCache();
public abstract org.chromium.net.ExperimentalUrlRequest$Builder setPriority(int);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor);
public abstract org.chromium.net.ExperimentalUrlRequest$Builder allowDirectExecutor();
public abstract org.chromium.net.ExperimentalUrlRequest build();
public org.chromium.net.UrlRequest build();
public org.chromium.net.UrlRequest$Builder allowDirectExecutor();
public org.chromium.net.UrlRequest$Builder setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor);
public org.chromium.net.UrlRequest$Builder setPriority(int);
public org.chromium.net.UrlRequest$Builder disableCache();
public org.chromium.net.UrlRequest$Builder addHeader(java.lang.String, java.lang.String);
public org.chromium.net.UrlRequest$Builder setHttpMethod(java.lang.String);
}
public abstract class org.chromium.net.ExperimentalUrlRequest extends org.chromium.net.UrlRequest {
public org.chromium.net.ExperimentalUrlRequest();
}
public abstract class org.chromium.net.ICronetEngineBuilder { public abstract class org.chromium.net.ICronetEngineBuilder {
public org.chromium.net.ICronetEngineBuilder(); public org.chromium.net.ICronetEngineBuilder();
public abstract org.chromium.net.ICronetEngineBuilder addPublicKeyPins(java.lang.String, java.util.Set<byte[]>, boolean, java.util.Date); public abstract org.chromium.net.ICronetEngineBuilder addPublicKeyPins(java.lang.String, java.util.Set<byte[]>, boolean, java.util.Date);
...@@ -294,4 +394,4 @@ public abstract class org.chromium.net.UrlResponseInfo { ...@@ -294,4 +394,4 @@ public abstract class org.chromium.net.UrlResponseInfo {
public abstract java.lang.String getProxyServer(); public abstract java.lang.String getProxyServer();
public abstract long getReceivedByteCount(); public abstract long getReceivedByteCount();
} }
Stamp: fadacc3f49758e52a33a1ae7f032ec97 Stamp: 71c5599220fcd59906505a5d599e5f7e
...@@ -74,9 +74,7 @@ def generate_api(api_jar, output_filename): ...@@ -74,9 +74,7 @@ def generate_api(api_jar, output_filename):
if CLASS_RE.match(line): if CLASS_RE.match(line):
skip_to_next_class = ( skip_to_next_class = (
# Skip internal classes, they aren't exposed. # Skip internal classes, they aren't exposed.
UNNAMED_CLASS_RE.match(line) or UNNAMED_CLASS_RE.match(line)
# Skip experimental classes, they can be modified.
'Experimental' in line
) )
if skip_to_next_class: if skip_to_next_class:
skip_to_next_class = line != '}' skip_to_next_class = line != '}'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment