Commit c6dba38d authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

ios: Pass -Wextra-semi to ObjC files with Xcode clang too.

https://reviews.llvm.org/rL356148 landed 1.5 years ago, it's hopefully
available in Xcode now. Also, we no longer support use_system_xcode
builds in chromium/ios.

Bug: 926235
Change-Id: I50e77e1b4c2e7419ab6be40fc00eb62b44548c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510190
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822659}
parent 8a6f1bd0
...@@ -1662,11 +1662,7 @@ config("chromium_code") { ...@@ -1662,11 +1662,7 @@ config("chromium_code") {
# ChromeOS: http://crbug.com/940863 # ChromeOS: http://crbug.com/940863
# Chromecast: http://crbug.com/942554 # Chromecast: http://crbug.com/942554
has_dchecks = is_debug || dcheck_always_on has_dchecks = is_debug || dcheck_always_on
if (!has_dchecks && is_ios && use_xcode_clang) { if (!has_dchecks && is_chromeos && is_chrome_branded) {
# TODO(thakis): Remove this branch once Xcode's clang has clang r356148.
cflags_c = [ "-Wextra-semi" ]
cflags_cc = [ "-Wextra-semi" ]
} else if (!has_dchecks && is_chromeos && is_chrome_branded) {
# Temporarily disable -Wextra-semi for Chrome on Chrome OS. # Temporarily disable -Wextra-semi for Chrome on Chrome OS.
} else if (is_chromecast && chromecast_branding != "public") { } else if (is_chromecast && chromecast_branding != "public") {
# Temporarily disable -Wextra-semi for Chromecast. # Temporarily disable -Wextra-semi for Chromecast.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment