Commit c6e5ca59 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in //chrome/browser/ui/views/tabs/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I2fdbfa0eac5fec5e3d995888ce830bece01e02cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382815Reviewed-by: default avatarConnie Wan <connily@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803168}
parent 6d61ec84
......@@ -1350,7 +1350,8 @@ void TabStrip::RemoveTabAt(content::WebContents* contents,
void TabStrip::SetTabData(int model_index, TabRendererData data) {
Tab* tab = tab_at(model_index);
const bool pinned_state_changed = tab->data().pinned != data.pinned;
const bool pinned = data.pinned;
const bool pinned_state_changed = tab->data().pinned != pinned;
tab->SetData(std::move(data));
if (HoverCardIsShowingForTab(tab))
......@@ -1364,7 +1365,7 @@ void TabStrip::SetTabData(int model_index, TabRendererData data) {
}
layout_helper_->SetTabPinned(
model_index, data.pinned ? TabPinned::kPinned : TabPinned::kUnpinned);
model_index, pinned ? TabPinned::kPinned : TabPinned::kUnpinned);
if (GetWidget() && GetWidget()->IsVisible())
StartPinnedTabAnimation();
else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment