Commit c6ee9921 authored by Shik Chen's avatar Shik Chen Committed by Commit Bot

CCA: Fix label check in presubmit

This CL fixes the following error by remove the 'for' attribute:
Avoid 'for' attribute on <label>. Place the input within the <label>, or
use aria-labelledby for <select>.

The <input> are already associate with <label> correctly as a direct
child.
ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

Bug: b/172879638, b/172340545
Test: Pass presubmit checks and manually check with Chromevox
Change-Id: Idcf38a2de244b9a3052a0831be28b72c522ca0bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554272
Commit-Queue: Shik Chen <shik@chromium.org>
Auto-Submit: Shik Chen <shik@chromium.org>
Reviewed-by: default avatarInker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830511}
parent 190d9ea9
...@@ -242,17 +242,17 @@ ...@@ -242,17 +242,17 @@
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div i18n-content="grid_type_button"></div> <div i18n-content="grid_type_button"></div>
</div> </div>
<label class="menu-item circle" for="grid-3x3"> <label class="menu-item circle">
<input class="icon" id="grid-3x3" type="radio" tabindex="0" <input class="icon" id="grid-3x3" type="radio" tabindex="0"
name="gridtype" data-state="_3x3" data-key="toggle3x3" checked> name="gridtype" data-state="_3x3" data-key="toggle3x3" checked>
<span i18n-content="label_grid_3x3" i18n-aria="aria_grid_3x3"></span> <span i18n-content="label_grid_3x3" i18n-aria="aria_grid_3x3"></span>
</label> </label>
<label class="menu-item circle" for="grid-4x4"> <label class="menu-item circle">
<input class="icon" id="grid-4x4" type="radio" tabindex="0" <input class="icon" id="grid-4x4" type="radio" tabindex="0"
name="gridtype" data-state="_4x4" data-key="toggle4x4"> name="gridtype" data-state="_4x4" data-key="toggle4x4">
<span i18n-content="label_grid_4x4" i18n-aria="aria_grid_4x4"></span> <span i18n-content="label_grid_4x4" i18n-aria="aria_grid_4x4"></span>
</label> </label>
<label class="menu-item circle" for="grid-golden"> <label class="menu-item circle">
<input class="icon" id="grid-golden" type="radio" tabindex="0" <input class="icon" id="grid-golden" type="radio" tabindex="0"
name="gridtype" data-state="golden" data-key="toggleGolden"> name="gridtype" data-state="golden" data-key="toggleGolden">
<span i18n-content="label_grid_golden"></span> <span i18n-content="label_grid_golden"></span>
...@@ -265,13 +265,13 @@ ...@@ -265,13 +265,13 @@
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div i18n-content="timer_duration_button"></div> <div i18n-content="timer_duration_button"></div>
</div> </div>
<label class="menu-item circle" for="timer-3s"> <label class="menu-item circle">
<input class="icon" id="timer-3s" type="radio" tabindex="0" <input class="icon" id="timer-3s" type="radio" tabindex="0"
name="timerdur" data-state="_3sec" data-key="toggle3sec" name="timerdur" data-state="_3sec" data-key="toggle3sec"
checked> checked>
<span i18n-content="label_timer_3s"></span> <span i18n-content="label_timer_3s"></span>
</label> </label>
<label class="menu-item circle" for="timer-10s"> <label class="menu-item circle">
<input class="icon" id="timer-10s" type="radio" tabindex="0" <input class="icon" id="timer-10s" type="radio" tabindex="0"
name="timerdur" data-state="_10sec" data-key="toggle10sec"> name="timerdur" data-state="_10sec" data-key="toggle10sec">
<span i18n-content="label_timer_10s"></span> <span i18n-content="label_timer_10s"></span>
...@@ -357,19 +357,19 @@ ...@@ -357,19 +357,19 @@
<button class="icon" tabindex="0" i18n-aria="back_button"></button> <button class="icon" tabindex="0" i18n-aria="back_button"></button>
<div i18n-content="expert_mode_button"></div> <div i18n-content="expert_mode_button"></div>
</div> </div>
<label class="menu-item" for="expert-show-metadata"> <label class="menu-item">
<input class="icon" id="expert-show-metadata" type="checkbox" <input class="icon" id="expert-show-metadata" type="checkbox"
tabindex="0" data-state="show-metadata" tabindex="0" data-state="show-metadata"
data-key="showMetadata"> data-key="showMetadata">
<span i18n-content="expert_preview_metadata"></span> <span i18n-content="expert_preview_metadata"></span>
</label> </label>
<label class="menu-item" for="expert-save-metadata"> <label class="menu-item">
<input class="icon" id="expert-save-metadata" type="checkbox" <input class="icon" id="expert-save-metadata" type="checkbox"
tabindex="0" data-state="save-metadata" tabindex="0" data-state="save-metadata"
data-key="saveMetadata"> data-key="saveMetadata">
<span i18n-content="expert_save_metadata"></span> <span i18n-content="expert_save_metadata"></span>
</label> </label>
<label class="menu-item" for="expert-print-performance-logs"> <label class="menu-item">
<input class="icon" id="expert-print-performance-logs" type="checkbox" <input class="icon" id="expert-print-performance-logs" type="checkbox"
tabindex="0" data-state="print-performance-logs" tabindex="0" data-state="print-performance-logs"
data-key="printPerformanceLogs"> data-key="printPerformanceLogs">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment