Commit c6f2eadb authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

Disable flaky test on Win and Linux.

Test:
BrowserNavigatorTest.ReuseRVHWithWebUI

See bug for falkiness dashboard link and sample failure.

TBR=ellyjones

Bug: 1044335
Change-Id: Ia5c8742a82aa8f750d46f011326a0fa2edeaee24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013756Reviewed-by: default avatarSebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734047}
parent ab734f56
......@@ -1818,12 +1818,19 @@ IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,
EXPECT_EQ(base::UTF8ToUTF16(expected_url), omnibox_view->GetText());
}
#if defined(OS_LINUX) || defined(OS_WIN)
// Flaky on Win and Linux. See https://crbug.com/1044335.
#define MAYBE_ReuseRVHWithWebUI DISABLED_ReuseRVHWithWebUI
#else
#define MAYBE_ReuseRVHWithWebUI ReuseRVHWithWebUI
#endif
// Test that there's no crash when a navigation to a WebUI page reuses an
// existing swapped out RenderViewHost. Previously, this led to a browser
// process crash in WebUI pages that use MojoWebUIController, which tried to
// use the RenderViewHost's GetMainFrame() when it was invalid in
// RenderViewCreated(). See https://crbug.com/627027.
IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, ReuseRVHWithWebUI) {
IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, MAYBE_ReuseRVHWithWebUI) {
ASSERT_TRUE(embedded_test_server()->Start());
// Visit a WebUI page with bindings.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment