Create a flag to implement keyboard shortcut viewer.

Create a flag to implement keyboard shortcut viewer. This flag will be
removed once the feature is launched.

Bug: 778874, 768932
Test: test new flag with command line, and chrome://flags.
Change-Id: I7ea41f990059a52c4a3f008fff9f8b9ba30da938
Reviewed-on: https://chromium-review.googlesource.com/740943
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513097}

ash/public/cpp/ash_switches.cc

@@ -24,6 +24,10 @@ const char kAshDeveloperShortcuts[] = "ash-dev-shortcuts";
 const char kAshDisableShelfModelSynchronization[] =
     "ash-disable-shelf-model-synchronization";
 
+// Disables a smoother animation for screen rotation.
+const char kAshDisableSmoothScreenRotation[] =
+    "ash-disable-smooth-screen-rotation";
+
 // Disables autohide titlebars feature. With this flag disabled, apps in tablet
 // mode will have visible titlebars instead of autohidden titlebars.
 // TODO(crbug.com/764393): Remove this flag in M66/M67.
@@ -40,6 +44,11 @@ const char kAshDisableTouchExplorationMode[] =
 // TODO(oshima): Remove this once the feature is launched. crbug.com/749713.
 const char kAshEnableV1AppBackButton[] = "ash-enable-v1-app-back-button";
 
+// Enables keyboard shortcut viewer.
+// TODO(wutao): Remove this once the feature is launched. crbug.com/768932.
+const char kAshEnableKeyboardShortcutViewer[] =
+    "ash-enable-keyboard-shortcut-viewer";
+
 // Enables key bindings to scroll magnified screen.
 const char kAshEnableMagnifierKeyScroller[] =
     "ash-enable-magnifier-key-scroller";
@@ -69,10 +78,6 @@ const char kAshEnableMirroredScreen[] = "ash-enable-mirrored-screen";
 // to modify the dsf of the device to any non discrete value.
 const char kAshEnableScaleSettingsTray[] = "ash-enable-scale-settings-tray";
 
-// Disables a smoother animation for screen rotation.
-const char kAshDisableSmoothScreenRotation[] =
-    "ash-disable-smooth-screen-rotation";
-
 // Specifies the estimated time (in milliseconds) from VSYNC event until when
 // visible light can be noticed by the user.
 const char kAshEstimatedPresentationDelay[] =

ash/public/cpp/ash_switches.h

@@ -24,6 +24,7 @@ ASH_PUBLIC_EXPORT extern const char kAshDisableSmoothScreenRotation[];
 ASH_PUBLIC_EXPORT extern const char kAshDisableTabletAutohideTitlebars[];
 ASH_PUBLIC_EXPORT extern const char kAshDisableTouchExplorationMode[];
 ASH_PUBLIC_EXPORT extern const char kAshEnableV1AppBackButton[];
+ASH_PUBLIC_EXPORT extern const char kAshEnableKeyboardShortcutViewer[];
 ASH_PUBLIC_EXPORT extern const char kAshEnableMagnifierKeyScroller[];
 ASH_PUBLIC_EXPORT extern const char kAshEnableNightLight[];
 ASH_PUBLIC_EXPORT extern const char kAshEnablePaletteOnAllDisplays[];

chrome/browser/about_flags.cc

@@ -3607,6 +3607,13 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(kExperimentalTabControllerFeature)},
 #endif  // defined(OS_WIN)
 
+#if defined(OS_CHROMEOS)
+    {"ash-enable-keyboard-shortcut-viewer",
+     flag_descriptions::kAshEnableKeyboardShortcutViewerName,
+     flag_descriptions::kAshEnableKeyboardShortcutViewerDescription, kOsCrOS,
+     SINGLE_VALUE_TYPE(ash::switches::kAshEnableKeyboardShortcutViewer)},
+#endif  // OS_CHROMEOS
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

chrome/browser/flag_descriptions.cc

@@ -2803,6 +2803,11 @@ const char kAshDisableSmoothScreenRotationName[] =
 const char kAshDisableSmoothScreenRotationDescription[] =
     "Disable smooth rotation animations.";
 
+const char kAshEnableKeyboardShortcutViewerName[] =
+    "Enable keyboard shortcut viewer.";
+const char kAshEnableKeyboardShortcutViewerDescription[] =
+    "Enable keyboard shortcut viewer.";
+
 const char kAshEnableMirroredScreenName[] = "Enable mirrored screen mode.";
 const char kAshEnableMirroredScreenDescription[] =
     "Enable the mirrored screen mode. This mode flips the screen image "

chrome/browser/flag_descriptions.h

@@ -1729,6 +1729,9 @@ extern const char kWebrtcH264WithOpenh264FfmpegDescription[];
 extern const char kAshDisableSmoothScreenRotationName[];
 extern const char kAshDisableSmoothScreenRotationDescription[];
 
+extern const char kAshEnableKeyboardShortcutViewerName[];
+extern const char kAshEnableKeyboardShortcutViewerDescription[];
+
 extern const char kAshEnableMirroredScreenName[];
 extern const char kAshEnableMirroredScreenDescription[];
 

tools/metrics/histograms/enums.xml

@@ -24493,6 +24493,7 @@ from previous Chrome versions.
   <int value="-723224470" label="enable-password-force-saving:enabled"/>
   <int value="-722474177" label="browser-side-navigation:disabled"/>
   <int value="-718626298" label="SysInternals:enabled"/>
+  <int value="-717281513" label="ash-enable-keyboard-shortcut-viewer"/>
   <int value="-716953514" label="disable-password-separated-signin-flow"/>
   <int value="-715733307" label="force-effective-connection-type"/>
   <int value="-714712077" label="ClickToOpenPDFPlaceholder:disabled"/>