Commit c71f4c7c authored by Andreas Papacharalampous's avatar Andreas Papacharalampous Committed by Commit Bot

extensions: change to singular term in context menu

when clicking the "Manage extensions" button in the context menu,
we go to the chrome://extensions page for that extension instead
of all the extensions.

Bug: 986890
Change-Id: I1e17b4ad0ffebc5c38591cc3fae2953efd8aa0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233303Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795279}
parent 47f65e6b
...@@ -4375,7 +4375,10 @@ are declared in tools/grit/grit_rule.gni. ...@@ -4375,7 +4375,10 @@ are declared in tools/grit/grit_rule.gni.
<message name="IDS_EXTENSIONS_UNPIN_FROM_TOOLBAR" desc="The text for the menu item to unpin an extension from the toolbar (sentence case)."> <message name="IDS_EXTENSIONS_UNPIN_FROM_TOOLBAR" desc="The text for the menu item to unpin an extension from the toolbar (sentence case).">
Unpin Unpin
</message> </message>
<message name="IDS_MANAGE_EXTENSION" desc="The 'Manage extensions' text in the context menu for when right-clicking on extension icons (sentence case)."> <message name="IDS_MANAGE_EXTENSION" desc="The text of the button in the extensions toolbar menu used to open the chrome://extensions/?id=xxx page and manage a specific extension (sentence case).">
Manage extension
</message>
<message name="IDS_MANAGE_EXTENSIONS" desc="The text of the button in the extensions toolbar menu used to open the chrome://extensions page and manage all extensions (sentence case).">
Manage extensions Manage extensions
</message> </message>
<message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (sentence case)."> <message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (sentence case).">
...@@ -4425,7 +4428,10 @@ are declared in tools/grit/grit_rule.gni. ...@@ -4425,7 +4428,10 @@ are declared in tools/grit/grit_rule.gni.
<message name="IDS_EXTENSIONS_UNPIN_FROM_TOOLBAR" desc="The text for the menu item to unpin an extension from the toolbar (title case)."> <message name="IDS_EXTENSIONS_UNPIN_FROM_TOOLBAR" desc="The text for the menu item to unpin an extension from the toolbar (title case).">
Unpin Unpin
</message> </message>
<message name="IDS_MANAGE_EXTENSION" desc="The 'Manage Extensions' text in the context menu for when right-clicking on extension icons (title case)."> <message name="IDS_MANAGE_EXTENSION" desc="The text of the button in the extensions toolbar menu used to open the chrome://extensions/?id=xxx page and manage a specific extension (title case).">
Manage Extension
</message>
<message name="IDS_MANAGE_EXTENSIONS" desc="The text of the button in the extensions toolbar menu used to open the chrome://extensions page and manage all extensions (title case).">
Manage Extensions Manage Extensions
</message> </message>
<message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (title case)."> <message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (title case).">
......
ddad08f0e2929c3a315cd1dc020111603bbc2f96
\ No newline at end of file
6a0b078c96d8677bb469218cbd98eb693a82c86d
\ No newline at end of file
...@@ -149,7 +149,7 @@ void ExtensionsMenuView::Populate() { ...@@ -149,7 +149,7 @@ void ExtensionsMenuView::Populate() {
AddChildView(std::make_unique<views::Separator>()); AddChildView(std::make_unique<views::Separator>());
auto footer = CreateBubbleMenuItem( auto footer = CreateBubbleMenuItem(
EXTENSIONS_SETTINGS_ID, l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSION), EXTENSIONS_SETTINGS_ID, l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS),
&button_listener_); &button_listener_);
footer->SetImage( footer->SetImage(
views::Button::STATE_NORMAL, views::Button::STATE_NORMAL,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment