Commit c7202017 authored by Alexander Timin's avatar Alexander Timin Committed by Commit Bot

Revert "Add tracing support for mojo handle kinds"

This reverts commit 19a1e60d.

Reason for revert: crbug.com/1117192

Original change's description:
> Add tracing support for mojo handle kinds
> 
> Support tracing of mojo handle and remote/receiver kinds. Thus provide
> more precise debugging information for developers. Also avoid
> generating fallback literals for base::trace_event::ValueToString.
> 
> Bug: 1103623
> Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005
> Commit-Queue: Karel Král <karelkral@google.com>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798588}

TBR=rockot@google.com,altimin@chromium.org,karelkral@google.com

Change-Id: I3fc0ca207c2b99324083c8f512903cf74757f8bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1103623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359083Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798726}
parent 24a84804
......@@ -362,15 +362,6 @@ def _WriteInputParamForTracingImpl(generator, kind, cpp_parameter_name,
for line in _WrapIfNullable(loop_generator):
yield line
return
if (mojom.IsAnyHandleOrInterfaceKind(kind)
and not mojom.IsAssociatedInterfaceRequestKind(kind)):
yield output_context.AddSingleValue('Boolean',
cpp_parameter_name + '.is_valid()')
return
if mojom.IsAssociatedInterfaceRequestKind(kind):
yield output_context.AddSingleValue('Boolean',
cpp_parameter_name + '.is_pending()')
return
yield output_context.AddSingleValue('String', _TraceEventToString())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment