Commit c725a5cf authored by kylechar's avatar kylechar Committed by Chromium LUCI CQ

Remove swap content bounds from SkiaRenderer

These data members were carried over from GLRenderer but are never
actually used. This is a no-op change.

Bug: 1161653
Change-Id: I2167b728b754a36200a21a7d18b461cec35e1cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643437Reviewed-by: default avatarPeng Huang <penghuang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845793}
parent b0429f8f
......@@ -752,9 +752,6 @@ void SkiaRenderer::FinishDrawingFrame() {
swap_buffer_rect_ = current_frame()->root_damage_rect;
if (use_swap_with_bounds_)
swap_content_bounds_ = current_frame()->root_content_bounds;
// TODO(weiliangc): Remove this once OverlayProcessor schedules overlays.
if (current_frame()->output_surface_plane) {
skia_output_surface_->ScheduleOutputSurfaceAsOverlay(
......@@ -771,13 +768,11 @@ void SkiaRenderer::SwapBuffers(SwapFrameData swap_frame_data) {
output_frame.top_controls_visible_height_changed =
swap_frame_data.top_controls_visible_height_changed;
output_frame.size = surface_size_for_swap_buffers();
if (use_swap_with_bounds_) {
output_frame.content_bounds = std::move(swap_content_bounds_);
} else if (use_partial_swap_) {
if (use_partial_swap_) {
swap_buffer_rect_.Intersect(gfx::Rect(surface_size_for_swap_buffers()));
output_frame.sub_buffer_rect = swap_buffer_rect_;
} else if (swap_buffer_rect_.IsEmpty() && allow_empty_swap_) {
output_frame.sub_buffer_rect = swap_buffer_rect_;
output_frame.sub_buffer_rect = gfx::Rect();
}
skia_output_surface_->SwapBuffers(std::move(output_frame));
......
......@@ -272,10 +272,7 @@ class VIZ_SERVICE_EXPORT SkiaRenderer : public DirectRenderer {
bool is_scissor_enabled_ = false;
gfx::Rect scissor_rect_;
// TODO(crbug.com/920344): Use partial swap for SkDDL.
bool use_swap_with_bounds_ = false;
gfx::Rect swap_buffer_rect_;
std::vector<gfx::Rect> swap_content_bounds_;
// State common to all quads in a batch. Draws that require an SkPaint not
// captured by this state cannot be batched.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment