Commit c72a79b0 authored by Jeffrey Kardatzke's avatar Jeffrey Kardatzke Committed by Commit Bot

Fix placement of Feedback UI Cancel/Send Buttons

This fixes the placement of the Cancel and Send buttons in the feedback
UI when the available screen area is smaller than the height of the
feedback dialog. Previously, in that case the buttons would be pinned to
the bottom of the viewport and the content in the dialog would scroll
underneath the buttons. This separates them out into a separate div and
removes their absolute positioning so that they no longer overlap. Some
other margin were changed as well in order to prevent it from having
60px of gap between the privacy notice and the buttons.

on current builds or another bug prevents this from being scrollable at
all

Bug: 866931
Test: Verified w/ and w/out magnifier on, SPM also needs to be disabled
Change-Id: Ic58ee0cd3e7251ae3a37fc623f8928e9522066b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504232Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#638263}
parent f597f833
......@@ -94,7 +94,7 @@ body {
}
.content .text-field-container > input[type=checkbox] {
margin-right: 9px;
margin-inline-end: 9px;
}
.content .checkbox-field-container {
......@@ -140,7 +140,7 @@ body {
color: #969696;
font-size: 12px;
line-height: 20px;
margin-bottom: 20px;
margin-bottom: 0;
margin-top: 20px;
text-align: justify;
text-justify: inter-word;
......@@ -159,6 +159,18 @@ body {
position: absolute;
}
#bottom-buttons-container {
margin: 0;
}
.content .bottom-buttons {
margin-bottom: 20px;
margin-inline-end: 20px;
margin-inline-start: 20px;
margin-top: 0;
position: static;
}
.content .remove-file-button {
background-color: transparent;
background-image: -webkit-image-set(
......
......@@ -101,8 +101,10 @@
</if>
<!-- Privacy note -->
<div id="privacy-note" i18n-values=".innerHTML:privacy-note"></div>
<!-- Buttons -->
<div class="buttons-pane">
</div>
<!-- Buttons -->
<div id="bottom-buttons-container" class="content">
<div class="buttons-pane bottom-buttons">
<button id="cancel-button" type="submit"
class="white-button" i18n-content="cancel">
</button>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment