Migrate off BrowserThread::DeleteSoon in /content/browser/android

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=skyostil@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I4bb88f91272c322e1056dfcb9b117f4ed21b6c2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895651
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711790}

content/browser/android/dialog_overlay_impl.cc

@@ -4,10 +4,12 @@
 
 #include "content/browser/android/dialog_overlay_impl.h"
 
+#include "base/task/post_task.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/android/content_jni_headers/DialogOverlayImpl_jni.h"
+#include "content/public/browser/browser_task_traits.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "gpu/ipc/common/gpu_surface_tracker.h"
@@ -134,7 +136,7 @@ void DialogOverlayImpl::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   UnregisterCallbacksIfNeeded();
   // We delete soon since this might be part of an onDismissed callback.
-  BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);
+  base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
 }
 
 void DialogOverlayImpl::GetCompositorOffset(