Commit c76223bc authored by Stepan Khapugin's avatar Stepan Khapugin Committed by Commit Bot

[multiball] Force browser-based fullscreen in multiwindow.

Forces ShouldScopeFullscreenControllerToBrowser to be enabled when in
multiwindow. This greatly improves usability with multiwindow.

Bug: 1069752, 1060653
Change-Id: I4521b4814ebd42aaadbe27c5252a8ef710928d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144108Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758238}
parent 7246f5bc
...@@ -890,11 +890,6 @@ NSString* const kBrowserViewControllerSnackbarCategory = ...@@ -890,11 +890,6 @@ NSString* const kBrowserViewControllerSnackbarCategory =
return; return;
_broadcasting = broadcasting; _broadcasting = broadcasting;
if (IsMultiwindowSupported()) {
// TODO(crbug.com/1060653): fix fullscreen.
return;
}
ChromeBroadcaster* broadcaster = self.fullscreenController->broadcaster(); ChromeBroadcaster* broadcaster = self.fullscreenController->broadcaster();
if (_broadcasting) { if (_broadcasting) {
_toolbarUIUpdater = [[LegacyToolbarUIUpdater alloc] _toolbarUIUpdater = [[LegacyToolbarUIUpdater alloc]
......
...@@ -39,6 +39,7 @@ source_set("feature_flags") { ...@@ -39,6 +39,7 @@ source_set("feature_flags") {
deps = [ deps = [
"//base", "//base",
"//components/flags_ui", "//components/flags_ui",
"//ios/chrome/browser/ui/util:multiwindow_util",
] ]
} }
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#import "ios/chrome/browser/ui/util/multi_window_support.h"
#if !defined(__has_feature) || !__has_feature(objc_arc) #if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support." #error "This file requires ARC support."
...@@ -25,6 +26,10 @@ bool ShouldUseSmoothScrolling() { ...@@ -25,6 +26,10 @@ bool ShouldUseSmoothScrolling() {
} }
bool ShouldScopeFullscreenControllerToBrowser() { bool ShouldScopeFullscreenControllerToBrowser() {
if (IsMultiwindowSupported()) {
return true;
}
return base::FeatureList::IsEnabled(kFullscreenControllerBrowserScoped); return base::FeatureList::IsEnabled(kFullscreenControllerBrowserScoped);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment