[vr] Remove URL bar throttling

This is an obsolete performance optimization.

Bug: None
Change-Id: I1b37a9bdc46b73aedaeeec65a86fe46cf8af081a
Reviewed-on: https://chromium-review.googlesource.com/563960Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485260}

chrome/browser/android/vr_shell/ui_elements/loading_indicator.cc

@@ -61,9 +61,4 @@ void LoadingIndicator::SetVisibility() {
   set_visible(enabled_ && (loading_ || visibility_timer_.IsRunning()));
 }
 
-void LoadingIndicator::OnBeginFrame(const base::TimeTicks& ticks) {
-  if (enabled_)
-    UpdateTexture();
-}
-
 }  // namespace vr_shell

chrome/browser/android/vr_shell/ui_elements/loading_indicator.h

@@ -24,7 +24,6 @@ class LoadingIndicator : public TexturedElement {
   void SetLoadProgress(float progress);
 
   void SetEnabled(bool enabled) override;
-  void OnBeginFrame(const base::TimeTicks& ticks) override;
 
  private:
   UiTexture* GetTexture() const override;

chrome/browser/android/vr_shell/ui_elements/textured_element.h

@@ -30,13 +30,14 @@ class TexturedElement : public UiElement {
   void Render(UiElementRenderer* renderer,
               gfx::Transform view_proj_matrix) const final;
 
-  void OnBeginFrame(const base::TimeTicks& begin_frame_time) override;
-
  protected:
+  void UpdateTexture();
+
   virtual UiTexture* GetTexture() const = 0;
-  virtual void UpdateTexture();
   virtual void UpdateElementSize();
 
+  void OnBeginFrame(const base::TimeTicks& begin_frame_time) final;
+
  private:
   void Flush(SkSurface* surface);
   void OnSetMode() override;

chrome/browser/android/vr_shell/ui_elements/url_bar.cc

@@ -9,16 +9,6 @@
 
 namespace vr_shell {
 
-namespace {
-
-// We will often get spammed with many updates. We will also get security and
-// url updates out of sync. To address both these problems, we will hang onto
-// dirtyness for |kUpdateDelay| before updating our texture to reduce visual
-// churn.
-constexpr int64_t kUpdateDelayMS = 50;
-
-}  // namespace
-
 UrlBar::UrlBar(int preferred_width,
                const base::Callback<void()>& back_button_callback,
                const base::Callback<void()>& security_icon_callback,
@@ -30,11 +20,6 @@ UrlBar::UrlBar(int preferred_width,
 
 UrlBar::~UrlBar() = default;
 
-void UrlBar::UpdateTexture() {
-  TexturedElement::UpdateTexture();
-  last_update_time_ = last_begin_frame_time_;
-}
-
 UiTexture* UrlBar::GetTexture() const {
   return texture_.get();
 }
@@ -74,20 +59,6 @@ bool UrlBar::HitTest(const gfx::PointF& position) const {
   return texture_->HitsUrlBar(position) || texture_->HitsBackButton(position);
 }
 
-void UrlBar::OnBeginFrame(const base::TimeTicks& begin_frame_time) {
-  last_begin_frame_time_ = begin_frame_time;
-  if (enabled_ && texture_->dirty()) {
-    int64_t delta_ms = (begin_frame_time - last_update_time_).InMilliseconds();
-    if (delta_ms > kUpdateDelayMS)
-      UpdateTexture();
-  }
-}
-
-void UrlBar::SetEnabled(bool enabled) {
-  enabled_ = enabled;
-  set_visible(enabled);
-}
-
 void UrlBar::SetToolbarState(const ToolbarState& state) {
   texture_->SetToolbarState(state);
 }

chrome/browser/android/vr_shell/ui_elements/url_bar.h

@@ -35,26 +35,19 @@ class UrlBar : public TexturedElement {
   void OnButtonUp(const gfx::PointF& position) override;
   bool HitTest(const gfx::PointF& point) const override;
 
-  void OnBeginFrame(const base::TimeTicks& begin_frame_time) override;
-  void SetEnabled(bool enabled) override;
-
   void SetHistoryButtonsEnabled(bool can_go_back);
   void SetToolbarState(const ToolbarState& state);
 
  private:
-  void UpdateTexture() override;
   UiTexture* GetTexture() const override;
   void OnStateUpdated(const gfx::PointF& position);
 
   std::unique_ptr<UrlBarTexture> texture_;
   base::Callback<void()> back_button_callback_;
   base::Callback<void()> security_icon_callback_;
-  bool enabled_ = false;
   bool can_go_back_ = false;
   bool down_ = false;
   bool security_region_down_ = false;
-  base::TimeTicks last_begin_frame_time_;
-  base::TimeTicks last_update_time_;
 
   DISALLOW_COPY_AND_ASSIGN(UrlBar);
 };