Commit c7865311 authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS][MF] Add histograms for autofill data types

Bug: 845472
Change-Id: I57c17eaa6add94d6defe8fea4e24c70bcb20af0b
Reviewed-on: https://chromium-review.googlesource.com/c/1329165
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607950}
parent e437d403
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#import "ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h" #import "ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h"
#include "base/ios/ios_util.h" #include "base/ios/ios_util.h"
#include "base/metrics/histogram_macros.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/action_cell.h" #import "ios/chrome/browser/ui/autofill/manual_fill/action_cell.h"
#import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h" #import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h"
#include "ios/chrome/browser/ui/util/ui_util.h" #include "ios/chrome/browser/ui/util/ui_util.h"
...@@ -37,6 +38,8 @@ NSString* const AddressTableViewAccessibilityIdentifier = ...@@ -37,6 +38,8 @@ NSString* const AddressTableViewAccessibilityIdentifier =
// TODO(crbug.com/845472): look at replacing ManualFillXXXConsumer with // TODO(crbug.com/845472): look at replacing ManualFillXXXConsumer with
// ManualFillItemsConsumer. // ManualFillItemsConsumer.
- (void)presentAddresses:(NSArray<ManualFillAddressItem*>*)addresses { - (void)presentAddresses:(NSArray<ManualFillAddressItem*>*)addresses {
UMA_HISTOGRAM_COUNTS_100("ManualFallback.PresentedOptions.Profiles",
addresses.count);
[self presentDataItems:(NSArray<TableViewItem*>*)addresses]; [self presentDataItems:(NSArray<TableViewItem*>*)addresses];
} }
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#import "ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.h" #import "ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.h"
#include "base/ios/ios_util.h" #include "base/ios/ios_util.h"
#include "base/metrics/histogram_macros.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/action_cell.h" #import "ios/chrome/browser/ui/autofill/manual_fill/action_cell.h"
#import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h" #import "ios/chrome/browser/ui/table_view/chrome_table_view_styler.h"
#include "ios/chrome/browser/ui/util/ui_util.h" #include "ios/chrome/browser/ui/util/ui_util.h"
...@@ -35,6 +36,8 @@ NSString* const CardTableViewAccessibilityIdentifier = ...@@ -35,6 +36,8 @@ NSString* const CardTableViewAccessibilityIdentifier =
#pragma mark - ManualFillCardConsumer #pragma mark - ManualFillCardConsumer
- (void)presentCards:(NSArray<ManualFillCardItem*>*)cards { - (void)presentCards:(NSArray<ManualFillCardItem*>*)cards {
UMA_HISTOGRAM_COUNTS_100("ManualFallback.PresentedOptions.CreditCards",
cards.count);
[self presentDataItems:(NSArray<TableViewItem*>*)cards]; [self presentDataItems:(NSArray<TableViewItem*>*)cards];
} }
......
...@@ -43152,6 +43152,15 @@ uploading your change for review. ...@@ -43152,6 +43152,15 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="ManualFallback.PresentedOptions.CreditCards" units="Cards"
expires_after="2019-12-31">
<owner>javierrobles@chromium.org</owner>
<summary>
Tracks the number of cards presented to the user in Manual Fallback. This is
logged everytime the user opens this view.
</summary>
</histogram>
<histogram name="ManualFallback.PresentedOptions.Passwords" units="Credentials" <histogram name="ManualFallback.PresentedOptions.Passwords" units="Credentials"
expires_after="2019-12-31"> expires_after="2019-12-31">
<owner>javierrobles@chromium.org</owner> <owner>javierrobles@chromium.org</owner>
...@@ -43161,6 +43170,15 @@ uploading your change for review. ...@@ -43161,6 +43170,15 @@ uploading your change for review.
</summary> </summary>
</histogram> </histogram>
<histogram name="ManualFallback.PresentedOptions.Profiles" units="Profiles"
expires_after="2019-12-31">
<owner>javierrobles@chromium.org</owner>
<summary>
Tracks the number of profiles presented to the user in Manual Fallback. This
is logged everytime the user opens this view.
</summary>
</histogram>
<histogram name="Media.AcceleratedCompositingActive" enum="BooleanSuccess"> <histogram name="Media.AcceleratedCompositingActive" enum="BooleanSuccess">
<obsolete> <obsolete>
Deprecated as of July 21, 2014. Deprecated as of July 21, 2014.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment