Commit c78893f5 authored by Mason Freed's avatar Mason Freed Committed by Chromium LUCI CQ

Rename SetNeedsAssignmentRecalc() to SetShadowRootNeedsAssignmentRecalc()

On HTMLSlotElement, this name makes more sense. From a comment at [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019/12/third_party/blink/renderer/core/html/html_slot_element.cc#684

Fixed: 1158844
Change-Id: I4d561071868f8db89a91c2a8d0d285c857cfb375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593284
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarYu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837293}
parent 90a7222e
......@@ -224,7 +224,7 @@ void HTMLSlotElement::assign(HeapVector<Member<Node>> nodes,
if (candidates_changed) {
assigned_nodes_candidates_.Swap(candidates);
ContainingShadowRoot()->GetSlotAssignment().SetNeedsAssignmentRecalc();
SetShadowRootNeedsAssignmentRecalc();
DidSlotChange(SlotChangeType::kSignalSlotChangeEvent);
}
}
......@@ -567,7 +567,7 @@ void HTMLSlotElement::DidSlotChangeAfterRemovedFromShadowTree() {
void HTMLSlotElement::DidSlotChangeAfterRenaming() {
DCHECK(SupportsAssignment());
EnqueueSlotChangeEvent();
SetNeedsAssignmentRecalc();
SetShadowRootNeedsAssignmentRecalc();
CheckSlotChange(SlotChangeType::kSuppressSlotChangeEvent);
}
......@@ -681,7 +681,7 @@ void HTMLSlotElement::NotifySlottedNodesOfFlatTreeChangeNaive(
}
}
void HTMLSlotElement::SetNeedsAssignmentRecalc() {
void HTMLSlotElement::SetShadowRootNeedsAssignmentRecalc() {
ContainingShadowRoot()->GetSlotAssignment().SetNeedsAssignmentRecalc();
}
......@@ -689,7 +689,7 @@ void HTMLSlotElement::DidSlotChange(SlotChangeType slot_change_type) {
DCHECK(SupportsAssignment());
if (slot_change_type == SlotChangeType::kSignalSlotChangeEvent)
EnqueueSlotChangeEvent();
SetNeedsAssignmentRecalc();
SetShadowRootNeedsAssignmentRecalc();
// Check slotchange recursively since this slotchange may cause another
// slotchange.
CheckSlotChange(SlotChangeType::kSuppressSlotChangeEvent);
......
......@@ -138,7 +138,7 @@ class CORE_EXPORT HTMLSlotElement final : public HTMLElement {
const HeapVector<Member<Node>>& old_slotted,
const HeapVector<Member<Node>>& new_slotted);
void SetNeedsAssignmentRecalc();
void SetShadowRootNeedsAssignmentRecalc();
bool CheckNodesValidity(HeapVector<Member<Node>> nodes, ExceptionState&);
// SlotAssignnment:recalc runs in tree order. Update to assigned order.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment