Commit c78e1aaf authored by Vlad Tsyrklevich's avatar Vlad Tsyrklevich Committed by Commit Bot

Revert "Add GWP-ASan hook to macOS crashpad handler"

This reverts commit dcea6896.

Reason for revert: The underlying change causes failures in the
headless_browsertests on Mac10.13 Tests (dbg)
https://bugs.chromium.org/p/chromium/issues/detail?id=929873

Original change's description:
> Add GWP-ASan hook to macOS crashpad handler
> 
> Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler.
> The GWP-ASan hook determines when an exception is related to GWP-ASan
> and reports additional debug information.
> 
> Bug: 912286
> Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e
> Reviewed-on: https://chromium-review.googlesource.com/c/1457461
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629881}

TBR=mark@chromium.org,vtsyrklevich@chromium.org

Change-Id: I9557c90e7ef6db6cf68e0b518538409783762395
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912286
Reviewed-on: https://chromium-review.googlesource.com/c/1459595Reviewed-by: default avatarVlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630066}
parent dc4aa5a7
...@@ -198,7 +198,6 @@ if (is_mac) { ...@@ -198,7 +198,6 @@ if (is_mac) {
] ]
deps = [ deps = [
"//components/gwp_asan/crash_handler",
"//third_party/crashpad/crashpad/handler:handler", "//third_party/crashpad/crashpad/handler:handler",
] ]
......
...@@ -2,16 +2,8 @@ ...@@ -2,16 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include <memory>
#include "components/gwp_asan/crash_handler/crash_handler.h"
#include "third_party/crashpad/crashpad/handler/handler_main.h" #include "third_party/crashpad/crashpad/handler/handler_main.h"
#include "third_party/crashpad/crashpad/handler/user_stream_data_source.h"
int main(int argc, char* argv[]) { int main(int argc, char* argv[]) {
crashpad::UserStreamDataSources user_stream_data_sources; return crashpad::HandlerMain(argc, argv, nullptr);
user_stream_data_sources.push_back(
std::make_unique<gwp_asan::UserStreamDataSource>());
return crashpad::HandlerMain(argc, argv, &user_stream_data_sources);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment