Omnibox - Enable Using HTTPS URLs for Suggestion Based on Context

Bug: 706071
Change-Id: Idcf5feefa594463a1b7295dd30025c1cbc489345
Reviewed-on: https://chromium-review.googlesource.com/578227Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488131}

chrome/browser/autocomplete/search_provider_unittest.cc

@@ -3305,18 +3305,18 @@ TEST_F(SearchProviderTest, CanSendURL) {
       metrics::OmniboxEventProto::OTHER, SearchTermsData(), &client));
 
   // Non-HTTP page URL on different domain.
-  EXPECT_FALSE(SearchProvider::CanSendURL(
+  EXPECT_TRUE(SearchProvider::CanSendURL(
       GURL("https://www.notgoogle.com/search"),
       GURL("https://www.google.com/complete/search"), &google_template_url,
       metrics::OmniboxEventProto::OTHER, SearchTermsData(), &client));
 
   // Non-HTTP page URL on different domain, yet with feature flag to allow
-  // this turned on.
+  // this turned off.
   {
     base::test::ScopedFeatureList feature_list;
-    feature_list.InitAndEnableFeature(
+    feature_list.InitAndDisableFeature(
         omnibox::kSearchProviderContextAllowHttpsUrls);
-    EXPECT_TRUE(SearchProvider::CanSendURL(
+    EXPECT_FALSE(SearchProvider::CanSendURL(
         GURL("https://www.notgoogle.com/search"),
         GURL("https://www.google.com/complete/search"), &google_template_url,
         metrics::OmniboxEventProto::OTHER, SearchTermsData(), &client));

components/omnibox/browser/omnibox_field_trial.cc

@@ -89,7 +89,7 @@ const base::Feature kSearchProviderWarmUpOnFocus{
 // transmit URLs for context in the first place).
 const base::Feature kSearchProviderContextAllowHttpsUrls{
     "OmniboixSearchProviderContextAllowHttpsUrls",
-    base::FEATURE_DISABLED_BY_DEFAULT};
+    base::FEATURE_ENABLED_BY_DEFAULT};
 
 // Feature used for the Zero Suggest Redirect to Chrome Field Trial.
 const base::Feature kZeroSuggestRedirectToChrome{