Commit c7b8db06 authored by achuith@chromium.org's avatar achuith@chromium.org

Make blocking_task_runner_ a member variable instead of sequence_token_.

BUG=NONE
TEST=unit tests.

Review URL: https://chromiumcodereview.appspot.com/10833020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148506 0039d316-1c4b-4281-b951-d872f2087c98
parent e0f3e144
...@@ -27,28 +27,22 @@ ...@@ -27,28 +27,22 @@
using content::BrowserContext; using content::BrowserContext;
using content::BrowserThread; using content::BrowserThread;
namespace gdata {
namespace { namespace {
// Used in test to setup system service. // Used in test to setup system service.
gdata::DocumentsServiceInterface* g_test_documents_service = NULL; DocumentsServiceInterface* g_test_documents_service = NULL;
const std::string* g_test_cache_root = NULL; const std::string* g_test_cache_root = NULL;
scoped_refptr<base::SequencedTaskRunner> GetTaskRunner( } // namespace
const base::SequencedWorkerPool::SequenceToken& sequence_token) {
return BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
sequence_token);
}
} // nemaspace
namespace gdata {
//===================== GDataSystemService ====================================
GDataSystemService::GDataSystemService(Profile* profile) GDataSystemService::GDataSystemService(Profile* profile)
: profile_(profile), : profile_(profile),
sequence_token_(BrowserThread::GetBlockingPool()->GetSequenceToken()),
cache_(NULL) { cache_(NULL) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
base::SequencedWorkerPool* blocking_pool = BrowserThread::GetBlockingPool();
blocking_task_runner_ = blocking_pool->GetSequencedTaskRunner(
blocking_pool->GetSequenceToken());
} }
GDataSystemService::~GDataSystemService() { GDataSystemService::~GDataSystemService() {
...@@ -64,7 +58,7 @@ void GDataSystemService::Initialize( ...@@ -64,7 +58,7 @@ void GDataSystemService::Initialize(
documents_service_.reset(documents_service); documents_service_.reset(documents_service);
cache_ = GDataCache::CreateGDataCacheOnUIThread( cache_ = GDataCache::CreateGDataCacheOnUIThread(
cache_root, cache_root,
GetTaskRunner(sequence_token_)); blocking_task_runner_);
uploader_.reset(new GDataUploader(docs_service())); uploader_.reset(new GDataUploader(docs_service()));
webapps_registry_.reset(new DriveWebAppsRegistry); webapps_registry_.reset(new DriveWebAppsRegistry);
file_system_.reset(new GDataFileSystem(profile_, file_system_.reset(new GDataFileSystem(profile_,
...@@ -72,7 +66,7 @@ void GDataSystemService::Initialize( ...@@ -72,7 +66,7 @@ void GDataSystemService::Initialize(
docs_service(), docs_service(),
uploader(), uploader(),
webapps_registry(), webapps_registry(),
GetTaskRunner(sequence_token_))); blocking_task_runner_));
download_observer_.reset(new GDataDownloadObserver(uploader(), download_observer_.reset(new GDataDownloadObserver(uploader(),
file_system())); file_system()));
sync_client_.reset(new GDataSyncClient(profile_, file_system(), cache())); sync_client_.reset(new GDataSyncClient(profile_, file_system(), cache()));
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_SYSTEM_SERVICE_H_ #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_SYSTEM_SERVICE_H_
#define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_SYSTEM_SERVICE_H_ #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_SYSTEM_SERVICE_H_
#include <string>
#include "base/memory/scoped_ptr.h" #include "base/memory/scoped_ptr.h"
#include "base/memory/singleton.h" #include "base/memory/singleton.h"
#include "base/threading/sequenced_worker_pool.h" #include "base/threading/sequenced_worker_pool.h"
...@@ -66,7 +68,7 @@ class GDataSystemService : public ProfileKeyedService { ...@@ -66,7 +68,7 @@ class GDataSystemService : public ProfileKeyedService {
friend class GDataSystemServiceFactory; friend class GDataSystemServiceFactory;
Profile* profile_; Profile* profile_;
const base::SequencedWorkerPool::SequenceToken sequence_token_; scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
GDataCache* cache_; GDataCache* cache_;
scoped_ptr<DocumentsServiceInterface> documents_service_; scoped_ptr<DocumentsServiceInterface> documents_service_;
scoped_ptr<GDataUploader> uploader_; scoped_ptr<GDataUploader> uploader_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment