Commit c7f0aa6a authored by Josh Karlin's avatar Josh Karlin Committed by Commit Bot

[AdsMetrics] Remove unused metric, PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound

Removes a metric that showed the resources loaded in non-ad
frames. This was never referenced so it's time to remove it.

Bug: 884233
Change-Id: Icc3522b515d757f4b58c30edcf7373da98453423
Reviewed-on: https://chromium-review.googlesource.com/1233937
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592931}
parent da63534f
...@@ -326,12 +326,6 @@ void AdsPageLoadMetricsObserver::ProcessLoadedResource( ...@@ -326,12 +326,6 @@ void AdsPageLoadMetricsObserver::ProcessLoadedResource(
// 2. possibly a resource from a document.written frame whose frame // 2. possibly a resource from a document.written frame whose frame
// failure message has yet to arrive. (uncertain of this) // failure message has yet to arrive. (uncertain of this)
} }
if (committed_) {
UMA_HISTOGRAM_ENUMERATION(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound",
extra_request_info.resource_type, content::RESOURCE_TYPE_LAST_TYPE);
}
return; return;
} }
......
...@@ -393,8 +393,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, AllAdTypesInPage) { ...@@ -393,8 +393,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, AllAdTypesInPage) {
AdType::ALL); AdType::ALL);
histogram_tester().ExpectBucketCount( histogram_tester().ExpectBucketCount(
"PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0); "PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0);
histogram_tester().ExpectTotalCount(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound", 0);
} }
// Test that the cross-origin ad subframe navigation metric works as it's // Test that the cross-origin ad subframe navigation metric works as it's
...@@ -478,8 +476,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, PageWithAdFrameThatRenavigates) { ...@@ -478,8 +476,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, PageWithAdFrameThatRenavigates) {
10 /* non_ad_uncached_kb */, AdType::GOOGLE); 10 /* non_ad_uncached_kb */, AdType::GOOGLE);
histogram_tester().ExpectBucketCount( histogram_tester().ExpectBucketCount(
"PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0); "PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0);
histogram_tester().ExpectTotalCount(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound", 0);
} }
TEST_F(AdsPageLoadMetricsObserverTest, PageWithNonAdFrameThatRenavigatesToAd) { TEST_F(AdsPageLoadMetricsObserverTest, PageWithNonAdFrameThatRenavigatesToAd) {
...@@ -514,8 +510,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, PageWithNonAdFrameThatRenavigatesToAd) { ...@@ -514,8 +510,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, PageWithNonAdFrameThatRenavigatesToAd) {
AdType::GOOGLE); AdType::GOOGLE);
histogram_tester().ExpectBucketCount( histogram_tester().ExpectBucketCount(
"PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0); "PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0);
histogram_tester().ExpectTotalCount(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound", 0);
} }
TEST_F(AdsPageLoadMetricsObserverTest, CountAbortedNavigation) { TEST_F(AdsPageLoadMetricsObserverTest, CountAbortedNavigation) {
...@@ -609,9 +603,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, TwoResourceLoadsBeforeCommit) { ...@@ -609,9 +603,6 @@ TEST_F(AdsPageLoadMetricsObserverTest, TwoResourceLoadsBeforeCommit) {
10 /* non_ad_uncached_kb */, AdType::GOOGLE); 10 /* non_ad_uncached_kb */, AdType::GOOGLE);
histogram_tester().ExpectBucketCount( histogram_tester().ExpectBucketCount(
"PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0); "PageLoad.Clients.Ads.All.ParentExistsForSubFrame", 0, 0);
histogram_tester().ExpectUniqueSample(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound",
content::RESOURCE_TYPE_SUB_FRAME, 1);
} }
// This tests an issue that is believed to be the cause of // This tests an issue that is believed to be the cause of
...@@ -644,12 +635,7 @@ TEST_F(AdsPageLoadMetricsObserverTest, FrameWithNoParent) { ...@@ -644,12 +635,7 @@ TEST_F(AdsPageLoadMetricsObserverTest, FrameWithNoParent) {
// Test that a resource loaded into an unknown frame doesn't cause any // Test that a resource loaded into an unknown frame doesn't cause any
// issues. // issues.
histogram_tester().ExpectTotalCount(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound", 0);
LoadResource(child_of_subframe, ResourceCached::NOT_CACHED, 10); LoadResource(child_of_subframe, ResourceCached::NOT_CACHED, 10);
histogram_tester().ExpectBucketCount(
"PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound",
content::RESOURCE_TYPE_SUB_FRAME, 1);
} }
TEST_F(AdsPageLoadMetricsObserverTest, MainFrameResource) { TEST_F(AdsPageLoadMetricsObserverTest, MainFrameResource) {
......
...@@ -69290,6 +69290,10 @@ uploading your change for review. ...@@ -69290,6 +69290,10 @@ uploading your change for review.
<histogram name="PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound" <histogram name="PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound"
enum="ContentResourceType2"> enum="ContentResourceType2">
<obsolete>
Deprecated in September 2018. At time of deprecation: Subframe 80%, Script
6.5%, Images 10%, and XHR was 3%.
</obsolete>
<owner>jkarlin@chromium.org</owner> <owner>jkarlin@chromium.org</owner>
<summary> <summary>
Records the content::ResourceType when a resource finishes loading but the Records the content::ResourceType when a resource finishes loading but the
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment