Silently swallow exceptions in extension bindings callbacks.

There are better ways to handle this, but I want a really
simple patch for merge.

BUG=106201
TEST=http://code.google.com/p/chromium/issues/detail?id=100401#c18

Review URL: http://codereview.chromium.org/8786008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112869 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/extension_bindings_apitest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Contains holistic tests of the bindings infrastructure
+
+#include "chrome/browser/extensions/extension_apitest.h"
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ExceptionInHandlerShouldNotCrash) {
+  ASSERT_TRUE(RunExtensionSubtest(
+      "bindings/exception_in_handler_should_not_crash",
+      "page.html")) << message_;
+}

chrome/chrome_tests.gypi

@@ -2498,6 +2498,7 @@
         'browser/extensions/extension_apitest.cc',
         'browser/extensions/extension_apitest.h',
         'browser/extensions/extension_apitest_apitest.cc',
+        'browser/extensions/extension_bindings_apitest.cc',
         'browser/extensions/extension_browsertest.cc',
         'browser/extensions/extension_browsertest.h',
         'browser/extensions/extension_browsertests_misc.cc',

chrome/renderer/extensions/chrome_v8_context.cc

@@ -83,7 +83,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
     v8::Handle<v8::Value>* argv,
     v8::Handle<v8::Value>* result) const {
   v8::Context::Scope context_scope(v8_context_);
-  v8::TryCatch try_catch;
 
   // Look up the function name, which may be a sub-property like
   // "Port.dispatchOnMessage" in the hidden global variable.
@@ -97,10 +96,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
     if (!value.IsEmpty() && value->IsObject()) {
       value = v8::Local<v8::Object>::Cast(value)->Get(
           v8::String::New(components[i].c_str()));
-      if (try_catch.HasCaught()) {
-        NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception());
-        return false;
-      }
     }
   }
 
@@ -111,10 +106,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
 
   v8::Handle<v8::Value> result_temp =
       v8::Local<v8::Function>::Cast(value)->Call(v8::Object::New(), argc, argv);
-  if (try_catch.HasCaught()) {
-    NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception());
-    return false;
-  }
   if (result)
     *result = result_temp;
   return true;

chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/manifest.json

+{
+  "name": "bug106201",
+  "version": "1"
+}

chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/page.html

+<script>
+chrome.tabs.create({}, function() {
+  throw new Error("tada");
+});
+chrome.tabs.create({}, function() {
+  chrome.test.notifyPass();
+});
+</script>