Commit c80d2e0b authored by Carlos IL's avatar Carlos IL Committed by Commit Bot

Revert "Reset simplified_domain_bounds_ on each animation start"

This reverts commit c82e8fea.

Reason for revert: Bugs remained after this CL, so both bidi handling CLs will be reverted until the bugs are fixed, we'll also merge a change that disables elision for bidi URLs to 86.

Original change's description:
> Reset simplified_domain_bounds_ on each animation start
> 
> simplified_domain_bounds_ is calculated on animation start via union,
> but was never being reset, this was causing bugs when an animation is
> reused (e.g. when switching tabs, or with URLs that redirect). This
> adds a reset.
> 
> Bug: 1117631
> Change-Id: I99d1eba536f39ad3c16fc09eca0aa79788b4bb62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382893
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Auto-Submit: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802826}

TBR=tommycli@chromium.org,carlosil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1117631
Change-Id: I4af20299fbf5e4351c51f468e48d50f53554a2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387482Reviewed-by: default avatarCarlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803604}
parent 102888c1
......@@ -211,7 +211,6 @@ void OmniboxViewViews::ElideAnimation::Start(
ranges_surrounding_simplified_domain.size() == 2
? ranges_surrounding_simplified_domain[1].start()
: elide_to_bounds.end());
simplified_domain_bounds_ = gfx::Rect();
for (auto rect : render_text_->GetSubstringBounds(simplified_domain_range)) {
simplified_domain_bounds_.Union(rect - render_text_->GetLineOffset(0));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment