Commit c812ddcd authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Add debugging for virtual MakeCurrent with no decoder.

Dump without crashing on Android if this happens.

Bug: 892490
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I824a4f4b9f09d3267113d6384370acae059e1690
Reviewed-on: https://chromium-review.googlesource.com/c/1266335Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597385}
parent 99359139
...@@ -13,6 +13,12 @@ ...@@ -13,6 +13,12 @@
#include "ui/gl/gpu_preference.h" #include "ui/gl/gpu_preference.h"
#include "ui/gl/gpu_timing.h" #include "ui/gl/gpu_timing.h"
// TODO(crbug.com/892490): remove this once the cause of this bug is
// known.
#if defined(OS_ANDROID)
#include "base/debug/dump_without_crashing.h"
#endif
namespace gpu { namespace gpu {
GLContextVirtual::GLContextVirtual(gl::GLShareGroup* share_group, GLContextVirtual::GLContextVirtual(gl::GLShareGroup* share_group,
...@@ -38,6 +44,11 @@ bool GLContextVirtual::MakeCurrent(gl::GLSurface* surface) { ...@@ -38,6 +44,11 @@ bool GLContextVirtual::MakeCurrent(gl::GLSurface* surface) {
return shared_context_->MakeVirtuallyCurrent(this, surface); return shared_context_->MakeVirtuallyCurrent(this, surface);
LOG(ERROR) << "Trying to make virtual context current without decoder."; LOG(ERROR) << "Trying to make virtual context current without decoder.";
// TODO(crbug.com/892490): remove this once the cause of this bug is
// known.
#if defined(OS_ANDROID)
base::debug::DumpWithoutCrashing();
#endif
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment