[cluster_telemetry] Add separate v8.loading_runtime_stats benchmark

Conditionally enablding runtime call stats is not straight forward. Hence we
add a separate benchmark that uses the slow RCS metrics.

Bug: chromium:883322
Change-Id: I66bc754f59ea62f0b7a922a3ca22535f568597d7
Reviewed-on: https://chromium-review.googlesource.com/c/1294034Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#601911}

tools/perf/contrib/cluster_telemetry/v8_loading_ct.py

@@ -7,24 +7,17 @@ from telemetry.web_perf import timeline_based_measurement
 
 # pylint: disable=protected-access
 class V8LoadingClusterTelemetry(loading_base_ct._LoadingBaseClusterTelemetry):
-
   @classmethod
-  def AddBenchmarkCommandLineArgs(cls, parser):
-    super(V8LoadingClusterTelemetry, cls).AddBenchmarkCommandLineArgs(parser)
-    parser.add_option('--enable-rcs', action='store_true', default=False,
-        help='Enable expensive V8 Runtime Call Stats metrics.')
+  def Name(cls):
+    return 'v8.loading.cluster_telemetry'
 
   @classmethod
   def ShouldAddValue(cls, name, from_first_story_run):
     del from_first_story_run  # unused
     return v8_browsing.V8BrowsingShouldAddValue(name)
 
-  @classmethod
-  def Name(cls):
-    return 'v8.loading.cluster_telemetry'
-
   def CreateCoreTimelineBasedMeasurementOptions(self):
     options = timeline_based_measurement.Options()
     v8_browsing.AugmentOptionsForV8BrowsingMetrics(options,
-        enable_runtime_call_stats=options.enable_rcs)
+        enable_runtime_call_stats=False)
     return options

tools/perf/contrib/cluster_telemetry/v8_loading_runtime_stats_ct.py

+# Copyright 2018 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+from benchmarks import v8_browsing
+from contrib.cluster_telemetry import loading_base_ct
+from telemetry.web_perf import timeline_based_measurement
+
+# pylint: disable=protected-access
+class V8LoadingRuntimeStatsClusterTelemetry(
+    loading_base_ct._LoadingBaseClusterTelemetry):
+
+  @classmethod
+  def Name(cls):
+    return 'v8.loading_runtime_stats.cluster_telemetry'
+
+  @classmethod
+  def ShouldAddValue(cls, name, from_first_story_run):
+    del from_first_story_run  # unused
+    return v8_browsing.V8BrowsingShouldAddValue(name)
+
+  def CreateCoreTimelineBasedMeasurementOptions(self):
+    options = timeline_based_measurement.Options()
+    v8_browsing.AugmentOptionsForV8BrowsingMetrics(options,
+        enable_runtime_call_stats=True)
+    return options

tools/perf/validate_wpr_archives

@@ -28,6 +28,7 @@ def GetAllStorySets():
       'multipage_skpicture_printer_ct',
       'loading.cluster_telemetry',
       'v8.loading.cluster_telemetry',
+      'v8.loading_runtime_stats.cluster_telemetry',
       'memory.cluster_telemetry',
       'skpicture_printer',
       'cros_tab_switching.typical_24',