Commit c83bb877 authored by Ryan Landay's avatar Ryan Landay Committed by Commit Bot

Split part of StackLayout into base class

This CL splits StackLayout into a base class and child class:

- StackLayoutBase is an abstract base class that contains most of the existing
  logic.

- StackLayout is a non-abstract child class that contains the pieces of
  existing logic that are assume there will always be exactly two stacks: one
  for all normal tabs, and one for all incognito tabs (the incognito stack is
  not displayed if empty).

This enables us to prototype new UIs on top of the tab switcher. I've already
built one prototype on top of this base class; we may end up needing to tweak
StackLayoutBase slightly as we build different types of prototypes, but I think
this is a pretty good start.

Bug: 648314
Change-Id: I25ca7169a1dfd3e780adea58ecb8043da9b55035
Reviewed-on: https://chromium-review.googlesource.com/957875Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543165}
parent 23e1f466
...@@ -209,6 +209,7 @@ chrome_java_sources = [ ...@@ -209,6 +209,7 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/ScrollDirection.java", "java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/ScrollDirection.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java", "java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java", "java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java", "java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java", "java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java",
"java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java", "java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment