Reland "Fix flaky printmanagement browser test"
This is a reland of 75e29f77 - The fix is to ensure that the print-management dom element is created and ready by the time we're querying for its child elements. - This was done by flushing the dom when the whenCalled promise is resolved, ensuring that the elements are ready. Original change's description: > Fix flaky printmanagement browser test > > - The original cause of the flaky is because the page element was not > ready by the time we try to query for elements within it. > - The fix is to attach a promise to the instatiation of the page and > to only continue with the test once the promise is resolved. This > ensures that each step of the test is handled synchronously. > > Bug: 1068860 > Test: browser_tests > Change-Id: I0a30e2971107b44354603adbb0396ddfea3c218d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142951 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757687} Bug: 1068860 Change-Id: I4b2e8b3836aa676c3d5aa43295432dd1afed6927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145253 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758135}
Showing
Please register or sign in to comment