Commit c8a0ba7d authored by Jeffrey Cohen's avatar Jeffrey Cohen Committed by Commit Bot

[SendTabToSelf] add field trail testing config for finch beta experiment.

Bug: 901429
Change-Id: Ib604a303a34d32fd1061f69015567c45137f2ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656049
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678489}
parent 72b0134b
...@@ -42,6 +42,7 @@ import org.chromium.base.test.util.CommandLineFlags; ...@@ -42,6 +42,7 @@ import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeTabbedActivity; import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.omnibox.UrlBar; import org.chromium.chrome.browser.omnibox.UrlBar;
...@@ -51,6 +52,7 @@ import org.chromium.chrome.test.ChromeJUnit4ClassRunner; ...@@ -51,6 +52,7 @@ import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.chrome.test.ChromeTabbedActivityTestRule; import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
import org.chromium.chrome.test.util.ChromeTabUtils; import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.chrome.test.util.OmniboxTestUtils; import org.chromium.chrome.test.util.OmniboxTestUtils;
import org.chromium.chrome.test.util.browser.Features.DisableFeatures;
import org.chromium.content_public.browser.test.util.TestThreadUtils; import org.chromium.content_public.browser.test.util.TestThreadUtils;
import org.chromium.ui.modaldialog.DialogDismissalCause; import org.chromium.ui.modaldialog.DialogDismissalCause;
import org.chromium.ui.modaldialog.ModalDialogManager; import org.chromium.ui.modaldialog.ModalDialogManager;
...@@ -111,9 +113,11 @@ public class TabModalPresenterTest { ...@@ -111,9 +113,11 @@ public class TabModalPresenterTest {
mTabModalPresenter.disableAnimationForTest(); mTabModalPresenter.disableAnimationForTest();
} }
// TODO(crbug/984793) remove explicit disabling for send_tab_to_self in this test.
@Test @Test
@SmallTest @SmallTest
@Feature({"ModalDialog"}) @Feature({"ModalDialog"})
@DisableFeatures(ChromeFeatureList.SEND_TAB_TO_SELF)
public void testShow_UrlBarFocused() throws Exception { public void testShow_UrlBarFocused() throws Exception {
// Show a tab modal dialog. The dialog should be shown on top of the toolbar. // Show a tab modal dialog. The dialog should be shown on top of the toolbar.
PropertyModel dialog1 = createDialog(mActivity, "1", null); PropertyModel dialog1 = createDialog(mActivity, "1", null);
......
...@@ -4672,6 +4672,26 @@ ...@@ -4672,6 +4672,26 @@
] ]
} }
], ],
"SendTabToSelfShowSendingUI": [
{
"platforms": [
"android",
"ios",
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"SendTabToSelfShowSendingUI"
]
}
]
}
],
"ServiceWorkerAggressiveCodeCache": [ "ServiceWorkerAggressiveCodeCache": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment