Move RenderWidgetTest ActivePinchGestureUpdatesLayerTreeHostSubFrame

Create a SimTest that initializes the MainFrame as a remote and port
the test over so that it is inside blink.
Delete render_widget_unittest.cc since no tests exist anymore in there.

BUG=1097816

Change-Id: I1268d1045a246d7756a3ba34f508963031feb997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462221
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816756}

content/renderer/render_widget_unittest.cc

-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "content/renderer/render_widget.h"
-
-#include <tuple>
-#include <utility>
-#include <vector>
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/macros.h"
-#include "base/optional.h"
-#include "base/run_loop.h"
-#include "base/test/metrics/histogram_tester.h"
-#include "base/test/task_environment.h"
-#include "base/unguessable_token.h"
-#include "build/build_config.h"
-#include "cc/layers/solid_color_layer.h"
-#include "cc/test/fake_layer_tree_frame_sink.h"
-#include "cc/trees/layer_tree_host.h"
-#include "components/viz/common/surfaces/parent_local_surface_id_allocator.h"
-#include "content/common/frame_replication_state.h"
-#include "content/common/input_messages.h"
-#include "content/common/view_messages.h"
-#include "content/common/widget_messages.h"
-#include "content/public/common/content_features.h"
-#include "content/public/test/fake_render_widget_host.h"
-#include "content/public/test/mock_render_thread.h"
-#include "content/renderer/agent_scheduling_group.h"
-#include "content/renderer/render_frame_proxy.h"
-#include "content/renderer/render_process.h"
-#include "content/renderer/render_widget_delegate.h"
-#include "content/test/fake_compositor_dependencies.h"
-#include "ipc/ipc_test_sink.h"
-#include "mojo/public/cpp/bindings/pending_associated_receiver.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/blink/public/common/input/synthetic_web_input_event_builders.h"
-#include "third_party/blink/public/common/input/web_coalesced_input_event.h"
-#include "third_party/blink/public/common/widget/device_emulation_params.h"
-#include "third_party/blink/public/common/widget/visual_properties.h"
-#include "third_party/blink/public/mojom/input/input_handler.mojom.h"
-#include "third_party/blink/public/mojom/page/widget.mojom-test-utils.h"
-#include "third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h"
-#include "third_party/blink/public/web/web_frame_widget.h"
-#include "third_party/blink/public/web/web_local_frame.h"
-#include "third_party/blink/public/web/web_local_frame_client.h"
-#include "third_party/blink/public/web/web_view.h"
-#include "third_party/blink/public/web/web_view_client.h"
-#include "ui/base/cursor/cursor.h"
-#include "ui/base/cursor/mojom/cursor_type.mojom-shared.h"
-#include "ui/events/base_event_utils.h"
-#include "ui/events/blink/web_input_event_traits.h"
-#include "ui/gfx/geometry/rect.h"
-
-using testing::_;
-
-namespace cc {
-class AnimationHost;
-}
-
-namespace content {
-
-namespace {
-
-std::unique_ptr<AgentSchedulingGroup> CreateAgentSchedulingGroup(
-    RenderThread& render_thread) {
-  mojo::PendingAssociatedRemote<mojom::AgentSchedulingGroupHost>
-      agent_scheduling_group_host;
-  ignore_result(
-      agent_scheduling_group_host.InitWithNewEndpointAndPassReceiver());
-  mojo::PendingAssociatedReceiver<mojom::AgentSchedulingGroup>
-      agent_scheduling_group_mojo;
-  return std::make_unique<AgentSchedulingGroup>(
-      render_thread, std::move(agent_scheduling_group_host),
-      std::move(agent_scheduling_group_mojo),
-      base::OnceCallback<void(const AgentSchedulingGroup*)>());
-}
-
-}  // namespace
-
-class InteractiveRenderWidget : public RenderWidget {
- public:
-  explicit InteractiveRenderWidget(AgentSchedulingGroup& agent_scheduling_group,
-                                   CompositorDependencies* compositor_deps)
-      : RenderWidget(agent_scheduling_group,
-                     ++next_routing_id_,
-                     compositor_deps) {}
-
-  void Init(blink::WebWidget* widget, const blink::ScreenInfo& screen_info) {
-    Initialize(base::NullCallback(), widget, screen_info);
-  }
-
-  using RenderWidget::Close;
-
-  IPC::TestSink* sink() { return &sink_; }
-
- protected:
-  bool Send(IPC::Message* msg) override {
-    sink_.OnMessageReceived(*msg);
-    delete msg;
-    return true;
-  }
-
- private:
-  IPC::TestSink sink_;
-  static int next_routing_id_;
-
-  DISALLOW_COPY_AND_ASSIGN(InteractiveRenderWidget);
-};
-
-int InteractiveRenderWidget::next_routing_id_ = 0;
-
-class RenderWidgetUnittest : public testing::Test {
- public:
-  explicit RenderWidgetUnittest(bool is_for_nested_main_frame = false)
-      : is_for_nested_main_frame_(is_for_nested_main_frame) {}
-
-  void SetUp() override {
-    mojo::AssociatedRemote<blink::mojom::FrameWidget> frame_widget_remote;
-    mojo::PendingAssociatedReceiver<blink::mojom::FrameWidget>
-        frame_widget_receiver =
-            frame_widget_remote.BindNewEndpointAndPassDedicatedReceiver();
-
-    mojo::AssociatedRemote<blink::mojom::FrameWidgetHost> frame_widget_host;
-    mojo::PendingAssociatedReceiver<blink::mojom::FrameWidgetHost>
-        frame_widget_host_receiver =
-            frame_widget_host.BindNewEndpointAndPassDedicatedReceiver();
-
-    mojo::AssociatedRemote<blink::mojom::Widget> widget_remote;
-    mojo::PendingAssociatedReceiver<blink::mojom::Widget> widget_receiver =
-        widget_remote.BindNewEndpointAndPassDedicatedReceiver();
-
-    mojo::AssociatedRemote<blink::mojom::WidgetHost> widget_host;
-    mojo::PendingAssociatedReceiver<blink::mojom::WidgetHost>
-        widget_host_receiver =
-            widget_host.BindNewEndpointAndPassDedicatedReceiver();
-
-    web_view_ = blink::WebView::Create(/*client=*/&web_view_client_,
-                                       /*is_hidden=*/false,
-                                       /*is_inside_portal=*/false,
-                                       /*compositing_enabled=*/true, nullptr,
-                                       mojo::NullAssociatedReceiver());
-    agent_scheduling_group_ = CreateAgentSchedulingGroup(render_thread_);
-    widget_ = std::make_unique<InteractiveRenderWidget>(
-        *agent_scheduling_group_, &compositor_deps_);
-    web_local_frame_ = blink::WebLocalFrame::CreateMainFrame(
-        web_view_, &web_frame_client_, nullptr,
-        base::UnguessableToken::Create(), nullptr);
-    web_frame_widget_ = blink::WebFrameWidget::CreateForMainFrame(
-        widget_.get(), web_local_frame_, frame_widget_host.Unbind(),
-        std::move(frame_widget_receiver), widget_host.Unbind(),
-        std::move(widget_receiver), is_for_nested_main_frame_);
-    widget_->Init(web_frame_widget_, blink::ScreenInfo());
-    web_view_->DidAttachLocalMainFrame();
-  }
-
-  void TearDown() override {
-    widget_->Close(std::move(widget_));
-    web_local_frame_ = nullptr;
-    web_frame_widget_ = nullptr;
-    web_view_ = nullptr;
-    // RenderWidget::Close() posts some destruction. Don't leak them.
-    base::RunLoop loop;
-    compositor_deps_.GetCleanupTaskRunner()->PostTask(FROM_HERE,
-                                                      loop.QuitClosure());
-    loop.Run();
-  }
-
-  InteractiveRenderWidget* widget() const { return widget_.get(); }
-
- private:
-  base::test::TaskEnvironment task_environment_;
-  RenderProcess render_process_;
-  MockRenderThread render_thread_;
-  blink::WebViewClient web_view_client_;
-  blink::WebView* web_view_;
-  blink::WebLocalFrame* web_local_frame_;
-  blink::WebFrameWidget* web_frame_widget_;
-  blink::WebLocalFrameClient web_frame_client_;
-  FakeCompositorDependencies compositor_deps_;
-  std::unique_ptr<AgentSchedulingGroup> agent_scheduling_group_;
-  std::unique_ptr<InteractiveRenderWidget> widget_;
-  const bool is_for_nested_main_frame_;
-};
-
-class RenderWidgetSubFrameUnittest : public RenderWidgetUnittest {
- public:
-  RenderWidgetSubFrameUnittest()
-      : RenderWidgetUnittest(/*is_for_nested_main_frame=*/true) {}
-};
-
-// Tests that the value of VisualProperties::is_pinch_gesture_active is
-// propagated to the LayerTreeHost when properties are synced for subframes.
-TEST_F(RenderWidgetSubFrameUnittest,
-       ActivePinchGestureUpdatesLayerTreeHostSubFrame) {
-  cc::LayerTreeHost* layer_tree_host = widget()->layer_tree_host();
-  EXPECT_FALSE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
-  blink::VisualProperties visual_properties;
-
-  // Sync visual properties on a child RenderWidget.
-  visual_properties.is_pinch_gesture_active = true;
-  widget()->GetWebWidget()->ApplyVisualProperties(visual_properties);
-  // We expect the |is_pinch_gesture_active| value to propagate to the
-  // LayerTreeHost for sub-frames. Since GesturePinch events are handled
-  // directly in the main-frame's layer tree (and only there), information about
-  // whether or not we're in a pinch gesture must be communicated separately to
-  // sub-frame layer trees, via OnUpdateVisualProperties. This information
-  // is required to allow sub-frame compositors to throttle rastering while
-  // pinch gestures are active.
-  EXPECT_TRUE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
-  visual_properties.is_pinch_gesture_active = false;
-  widget()->GetWebWidget()->ApplyVisualProperties(visual_properties);
-  EXPECT_FALSE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
-}
-
-}  // namespace content

content/test/BUILD.gn

@@ -2035,7 +2035,6 @@ test("content_unittests") {
     "../renderer/media/renderer_webaudiodevice_impl_unittest.cc",
     "../renderer/peripheral_content_heuristic_unittest.cc",
     "../renderer/render_thread_impl_unittest.cc",
-    "../renderer/render_widget_unittest.cc",
     "../renderer/service_worker/service_worker_fetch_context_impl_unittest.cc",
     "../renderer/service_worker/service_worker_provider_context_unittest.cc",
     "../renderer/service_worker/service_worker_subresource_loader_unittest.cc",

third_party/blink/renderer/core/frame/web_frame_widget_test.cc

@@ -10,6 +10,7 @@
 #include "cc/layers/solid_color_layer.h"
 #include "components/viz/common/surfaces/parent_local_surface_id_allocator.h"
 #include "third_party/blink/public/common/input/synthetic_web_input_event_builders.h"
+#include "third_party/blink/renderer/core/frame/web_frame_widget_impl.h"
 #include "third_party/blink/renderer/core/frame/web_view_frame_widget.h"
 #include "third_party/blink/renderer/core/testing/sim/sim_request.h"
 #include "third_party/blink/renderer/core/testing/sim/sim_test.h"
@@ -117,6 +118,47 @@ TEST_F(WebFrameWidgetSimTest, ForceSendMetadataOnInput) {
 }
 #endif  // defined(OS_ANDROID)
 
+// A test that forces a RemoteMainFrame to be created and the LocalFrameRoot
+// to be a WebFrameWidgetImpl.
+class WebFrameWidgetImplSimTest : public SimTest {
+ public:
+  void SetUp() override {
+    SimTest::SetUp();
+    InitializeRemote();
+    CHECK(static_cast<WebFrameWidgetBase*>(LocalFrameRoot().FrameWidget())
+              ->ForSubframe());
+  }
+
+  WebFrameWidgetImpl* LocalFrameRootWidget() {
+    return static_cast<WebFrameWidgetImpl*>(LocalFrameRoot().FrameWidget());
+  }
+};
+
+// Tests that the value of VisualProperties::is_pinch_gesture_active is
+// propagated to the LayerTreeHost when properties are synced for child local
+// roots.
+TEST_F(WebFrameWidgetImplSimTest,
+       ActivePinchGestureUpdatesLayerTreeHostSubFrame) {
+  cc::LayerTreeHost* layer_tree_host = LocalFrameRootWidget()->LayerTreeHost();
+  EXPECT_FALSE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
+  blink::VisualProperties visual_properties;
+
+  // Sync visual properties on a child widget.
+  visual_properties.is_pinch_gesture_active = true;
+  LocalFrameRootWidget()->ApplyVisualProperties(visual_properties);
+  // We expect the |is_pinch_gesture_active| value to propagate to the
+  // LayerTreeHost for sub-frames. Since GesturePinch events are handled
+  // directly in the main-frame's layer tree (and only there), information about
+  // whether or not we're in a pinch gesture must be communicated separately to
+  // sub-frame layer trees, via OnUpdateVisualProperties. This information
+  // is required to allow sub-frame compositors to throttle rastering while
+  // pinch gestures are active.
+  EXPECT_TRUE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
+  visual_properties.is_pinch_gesture_active = false;
+  LocalFrameRootWidget()->ApplyVisualProperties(visual_properties);
+  EXPECT_FALSE(layer_tree_host->is_external_pinch_gesture_active_for_testing());
+}
+
 const char EVENT_LISTENER_RESULT_HISTOGRAM[] = "Event.PassiveListeners";
 
 // Keep in sync with enum defined in