Commit c8ddf08f authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Remove BlockingURLFetcherDelegate from a variations browser test.

The code is no longer in use, since variations now uses the network
service's URLLoader interface, instead of URLFetchers.

Bug: None
Change-Id: If506394f8abbdc4bc5ea166652dbdabcda8f172d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612046
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659731}
parent 6cbf3f75
...@@ -34,8 +34,6 @@ ...@@ -34,8 +34,6 @@
#include "net/test/embedded_test_server/http_request.h" #include "net/test/embedded_test_server/http_request.h"
#include "net/test/embedded_test_server/http_response.h" #include "net/test/embedded_test_server/http_response.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" #include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "services/network/public/cpp/features.h" #include "services/network/public/cpp/features.h"
#include "services/network/public/cpp/shared_url_loader_factory.h" #include "services/network/public/cpp/shared_url_loader_factory.h"
#include "services/network/public/cpp/simple_url_loader.h" #include "services/network/public/cpp/simple_url_loader.h"
...@@ -256,24 +254,6 @@ class VariationsHttpHeadersBrowserTest : public InProcessBrowserTest { ...@@ -256,24 +254,6 @@ class VariationsHttpHeadersBrowserTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(VariationsHttpHeadersBrowserTest); DISALLOW_COPY_AND_ASSIGN(VariationsHttpHeadersBrowserTest);
}; };
class BlockingURLFetcherDelegate : public net::URLFetcherDelegate {
public:
BlockingURLFetcherDelegate() = default;
~BlockingURLFetcherDelegate() override = default;
void OnURLFetchComplete(const net::URLFetcher* source) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
run_loop_.QuitClosure());
}
void AwaitResponse() { run_loop_.Run(); }
private:
base::RunLoop run_loop_;
DISALLOW_COPY_AND_ASSIGN(BlockingURLFetcherDelegate);
};
std::unique_ptr<net::test_server::HttpResponse> std::unique_ptr<net::test_server::HttpResponse>
VariationsHttpHeadersBrowserTest::RequestHandler( VariationsHttpHeadersBrowserTest::RequestHandler(
const net::test_server::HttpRequest& request) { const net::test_server::HttpRequest& request) {
...@@ -332,8 +312,7 @@ IN_PROC_BROWSER_TEST_F(VariationsHttpHeadersBrowserTest, ...@@ -332,8 +312,7 @@ IN_PROC_BROWSER_TEST_F(VariationsHttpHeadersBrowserTest,
} }
// Verify in an integration that that the variations header (X-Client-Data) is // Verify in an integration that that the variations header (X-Client-Data) is
// correctly attached and stripped from network requests that are triggered via // correctly attached and stripped from network requests.
// a URLFetcher.
IN_PROC_BROWSER_TEST_F(VariationsHttpHeadersBrowserTest, IN_PROC_BROWSER_TEST_F(VariationsHttpHeadersBrowserTest,
TestStrippingHeadersFromSubresourceRequest) { TestStrippingHeadersFromSubresourceRequest) {
GURL url = server()->GetURL("/simple_page.html"); GURL url = server()->GetURL("/simple_page.html");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment