Commit c8f1338f authored by Dave Tapuska's avatar Dave Tapuska Committed by Commit Bot

Remove DidNotProduceFrame view message

This message is only generated for sync compositor and was discarded
when we weren't using the browser compositor. That makes the message
useless. Seems to be left over from when viz moved its begin frame
messaging.

BUG=722928

Change-Id: I65fa542b937c87568e63c25faca436e6a4939365
Reviewed-on: https://chromium-review.googlesource.com/889324
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533696}
parent e37f76e5
...@@ -601,7 +601,6 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) { ...@@ -601,7 +601,6 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) {
OnUpdateScreenRectsAck) OnUpdateScreenRectsAck)
IPC_MESSAGE_HANDLER(ViewHostMsg_RequestMove, OnRequestMove) IPC_MESSAGE_HANDLER(ViewHostMsg_RequestMove, OnRequestMove)
IPC_MESSAGE_HANDLER(ViewHostMsg_SetTooltipText, OnSetTooltipText) IPC_MESSAGE_HANDLER(ViewHostMsg_SetTooltipText, OnSetTooltipText)
IPC_MESSAGE_HANDLER(ViewHostMsg_DidNotProduceFrame, DidNotProduceFrame)
IPC_MESSAGE_HANDLER(ViewHostMsg_ResizeOrRepaint_ACK, OnResizeOrRepaintACK) IPC_MESSAGE_HANDLER(ViewHostMsg_ResizeOrRepaint_ACK, OnResizeOrRepaintACK)
IPC_MESSAGE_HANDLER(ViewHostMsg_SetCursor, OnSetCursor) IPC_MESSAGE_HANDLER(ViewHostMsg_SetCursor, OnSetCursor)
IPC_MESSAGE_HANDLER(ViewHostMsg_AutoscrollStart, OnAutoscrollStart) IPC_MESSAGE_HANDLER(ViewHostMsg_AutoscrollStart, OnAutoscrollStart)
......
...@@ -1291,6 +1291,7 @@ void RenderWidgetHostViewAndroid::OnDidNotProduceFrame( ...@@ -1291,6 +1291,7 @@ void RenderWidgetHostViewAndroid::OnDidNotProduceFrame(
void RenderWidgetHostViewAndroid::AcknowledgeBeginFrame( void RenderWidgetHostViewAndroid::AcknowledgeBeginFrame(
const viz::BeginFrameAck& ack) { const viz::BeginFrameAck& ack) {
// AcknowledgeBeginFrame is not called for the synchronous compositor path.
if (begin_frame_source_) if (begin_frame_source_)
begin_frame_source_->DidFinishFrame(this); begin_frame_source_->DidFinishFrame(this);
} }
......
...@@ -718,11 +718,6 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_FrameSwapMessages, ...@@ -718,11 +718,6 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_FrameSwapMessages,
uint32_t /* frame_token */, uint32_t /* frame_token */,
std::vector<IPC::Message> /* messages */) std::vector<IPC::Message> /* messages */)
// Sent if the BeginFrame did not cause a SwapCompositorFrame (e.g. because no
// updates were required or because it was aborted in the renderer).
IPC_MESSAGE_ROUTED1(ViewHostMsg_DidNotProduceFrame,
viz::BeginFrameAck /* ack */)
// Send back a string to be recorded by UserMetrics. // Send back a string to be recorded by UserMetrics.
IPC_MESSAGE_CONTROL1(ViewHostMsg_UserMetricsRecordAction, IPC_MESSAGE_CONTROL1(ViewHostMsg_UserMetricsRecordAction,
std::string /* action */) std::string /* action */)
......
...@@ -340,9 +340,6 @@ void SynchronousLayerTreeFrameSink::SubmitCompositorFrame( ...@@ -340,9 +340,6 @@ void SynchronousLayerTreeFrameSink::SubmitCompositorFrame(
void SynchronousLayerTreeFrameSink::DidNotProduceFrame( void SynchronousLayerTreeFrameSink::DidNotProduceFrame(
const viz::BeginFrameAck& ack) { const viz::BeginFrameAck& ack) {
DCHECK(!ack.has_damage);
DCHECK_LE(viz::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
Send(new ViewHostMsg_DidNotProduceFrame(routing_id_, ack));
} }
void SynchronousLayerTreeFrameSink::CancelFallbackTick() { void SynchronousLayerTreeFrameSink::CancelFallbackTick() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment