Commit c908b143 authored by Philipp Hancke's avatar Philipp Hancke Committed by Commit Bot

webrtc-internals: dont calculate stun rtt in milliseconds

the related standard currentRoundTripTime is defined in seconds:
  https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
and having the calculated stat on a different timescale is confusing.

BUG=None

Change-Id: Iac04deef1bb0c346c5bd7e08a944764b4c29e845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300100Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#803426}
parent a3fe3867
...@@ -512,9 +512,8 @@ class StatsRatesCalculator { ...@@ -512,9 +512,8 @@ class StatsRatesCalculator {
'bytesReceived', 'timestamp', CalculatorModifier.kBytesToBits), 'bytesReceived', 'timestamp', CalculatorModifier.kBytesToBits),
// TODO(https://crbug.com/webrtc/10569): Add packetsSent and // TODO(https://crbug.com/webrtc/10569): Add packetsSent and
// packetsReceived once implemented. // packetsReceived once implemented.
totalRoundTripTime: new RateCalculator( totalRoundTripTime:
'totalRoundTripTime', 'responsesReceived', new RateCalculator('totalRoundTripTime', 'responsesReceived'),
CalculatorModifier.kMillisecondsFromSeconds),
}, },
}, },
]; ];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment