Remove smoothness.scrolling_tough_ad_cases benchmark

This benchmark has been failing on all platforms for a while and we don't have
bandwidth to revive it.

Bug: 683247
Change-Id: I57280d16f43403cd3447c7c1f315e3084e6c4aa1
Reviewed-on: https://chromium-review.googlesource.com/578107
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489416}

testing/buildbot/chromium.perf.fyi.json

@@ -2989,65 +2989,6 @@
           "io_timeout": 3600
         }
       },
-      {
-        "args": [
-          "smoothness.scrolling_tough_ad_cases",
-          "-v",
-          "--upload-results",
-          "--output-format=chartjson",
-          "--browser=release_x64"
-        ],
-        "isolate_name": "telemetry_perf_tests",
-        "name": "smoothness.scrolling_tough_ad_cases",
-        "override_compile_targets": [
-          "telemetry_perf_tests"
-        ],
-        "swarming": {
-          "can_use_on_swarming_builders": true,
-          "dimension_sets": [
-            {
-              "gpu": "8086:22b1",
-              "id": "build149-b1",
-              "os": "Windows-10-10586",
-              "pool": "Chrome-perf-fyi"
-            }
-          ],
-          "expiration": 36000,
-          "hard_timeout": 10800,
-          "ignore_task_failure": false,
-          "io_timeout": 3600
-        }
-      },
-      {
-        "args": [
-          "smoothness.scrolling_tough_ad_cases",
-          "-v",
-          "--upload-results",
-          "--output-format=chartjson",
-          "--browser=reference",
-          "--output-trace-tag=_ref"
-        ],
-        "isolate_name": "telemetry_perf_tests",
-        "name": "smoothness.scrolling_tough_ad_cases.reference",
-        "override_compile_targets": [
-          "telemetry_perf_tests"
-        ],
-        "swarming": {
-          "can_use_on_swarming_builders": true,
-          "dimension_sets": [
-            {
-              "gpu": "8086:22b1",
-              "id": "build149-b1",
-              "os": "Windows-10-10586",
-              "pool": "Chrome-perf-fyi"
-            }
-          ],
-          "expiration": 36000,
-          "hard_timeout": 10800,
-          "ignore_task_failure": true,
-          "io_timeout": 3600
-        }
-      },
       {
         "args": [
           "smoothness.top_25_smooth",
@@ -7943,65 +7884,6 @@
           "io_timeout": 3600
         }
       },
-      {
-        "args": [
-          "smoothness.scrolling_tough_ad_cases",
-          "-v",
-          "--upload-results",
-          "--output-format=chartjson",
-          "--browser=release_x64"
-        ],
-        "isolate_name": "telemetry_perf_tests",
-        "name": "smoothness.scrolling_tough_ad_cases",
-        "override_compile_targets": [
-          "telemetry_perf_tests"
-        ],
-        "swarming": {
-          "can_use_on_swarming_builders": true,
-          "dimension_sets": [
-            {
-              "gpu": "1002:9874",
-              "id": "build213-b4",
-              "os": "Windows-10-10586",
-              "pool": "Chrome-perf-fyi"
-            }
-          ],
-          "expiration": 36000,
-          "hard_timeout": 10800,
-          "ignore_task_failure": false,
-          "io_timeout": 3600
-        }
-      },
-      {
-        "args": [
-          "smoothness.scrolling_tough_ad_cases",
-          "-v",
-          "--upload-results",
-          "--output-format=chartjson",
-          "--browser=reference",
-          "--output-trace-tag=_ref"
-        ],
-        "isolate_name": "telemetry_perf_tests",
-        "name": "smoothness.scrolling_tough_ad_cases.reference",
-        "override_compile_targets": [
-          "telemetry_perf_tests"
-        ],
-        "swarming": {
-          "can_use_on_swarming_builders": true,
-          "dimension_sets": [
-            {
-              "gpu": "1002:9874",
-              "id": "build213-b4",
-              "os": "Windows-10-10586",
-              "pool": "Chrome-perf-fyi"
-            }
-          ],
-          "expiration": 36000,
-          "hard_timeout": 10800,
-          "ignore_task_failure": true,
-          "io_timeout": 3600
-        }
-      },
       {
         "args": [
           "smoothness.top_25_smooth",

tools/perf/benchmark.csv

@@ -75,7 +75,6 @@ smoothness.key_mobile_sites_smooth,"vmiura@chromium.org, tdresser@chromium.org",
 smoothness.key_silk_cases,ajuma@chromium.org,
 smoothness.maps,"kbr@chromium.org, zmo@chromium.org",
 smoothness.pathological_mobile_sites,picksi@chromium.org,
-smoothness.scrolling_tough_ad_cases,skyostil@chromium.org,
 smoothness.simple_mobile_sites,vmiura@chromium.org,
 smoothness.sync_scroll.key_mobile_sites_smooth,"tdresser@chromium.org, rbyers@chromium.org",
 smoothness.top_25_smooth,vmiura@chromium.org,

tools/perf/benchmarks/smoothness.py

@@ -689,34 +689,6 @@ class SmoothnessToughAdCases(_Smoothness):
     return StoryExpectations()
 
 
-# http://crbug.com/522619 (mac/win)
-# http://crbug.com/683247 (android/linux)
-@benchmark.Disabled('win', 'mac', 'android', 'linux')
-@benchmark.Owner(emails=['skyostil@chromium.org'])
-class SmoothnessScrollingToughAdCases(_Smoothness):
-  """Measures rendering statistics while scrolling advertisements."""
-  page_set = page_sets.ScrollingToughAdCasesPageSet
-
-  @classmethod
-  def ShouldDisable(cls, possible_browser):  # http://crbug.com/597656
-    return (possible_browser.browser_type == 'reference' and
-            possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
-
-  @classmethod
-  def Name(cls):
-    return 'smoothness.scrolling_tough_ad_cases'
-
-  def GetExpectations(self):
-    class StoryExpectations(story_module.expectations.StoryExpectations):
-      def SetExpectations(self):
-        self.DisableStory(
-            'http://time.com/3977891/donald-trump-debate-republican/',
-            [story_module.expectations.ALL], 'crbug.com/520509')
-        self.DisableStory(
-            'http://m.tmz.com', [story_module.expectations.ALL], 'crbug.com/597656')
-    return StoryExpectations()
-
-
 @benchmark.Owner(emails=['skyostil@chromium.org'])
 class SmoothnessToughWebGLAdCases(_Smoothness):
   """Measures rendering statistics while scrolling advertisements."""

tools/perf/page_sets/tough_ad_cases.py

@@ -209,11 +209,3 @@ class ToughAdCasesPageSet(story.StorySet):
         y_scroll_distance_multiplier=0.25))
     self.AddStory(AdPage('http://androidpolice.com', self, scroll=scroll,
         wait_for_interactive_or_better=True))
-
-
-class ScrollingToughAdCasesPageSet(ToughAdCasesPageSet):
-  """Pages for measuring scrolling performance with advertising content."""
-
-  def __init__(self):
-    super(ScrollingToughAdCasesPageSet, self).__init__(
-        scroll=True)