Differentiate MV tile and Omnibox use on Start Surface.

Add vertical space below MV tiles.

R=yusufo@chromium.org

Bug: 985386
Change-Id: Id72f1339c9150530248173e5a9dc4bec6681fc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808792Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697692}

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/MostVisitedListCoordinator.java

@@ -144,7 +144,7 @@ class MostVisitedListCoordinator implements TileGroup.Observer, TileGroup.TileSe
 
         @Override
         public void onClick(View v) {
-            ReturnToChromeExperimentsUtil.willHandleLoadUrlFromLocationBar(
+            ReturnToChromeExperimentsUtil.willHandleLoadUrlFromStartSurface(
                     mTile.getUrl(), PageTransition.AUTO_BOOKMARK);
         }
 

chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -937,7 +937,9 @@ public class LocationBarLayout extends FrameLayout
         // side is initialized
         assert mNativeInitialized : "Loading URL before native side initialized";
 
-        if (ReturnToChromeExperimentsUtil.willHandleLoadUrlFromLocationBar(url, transition)) return;
+        if (ReturnToChromeExperimentsUtil.willHandleLoadUrlFromStartSurface(url, transition)) {
+            return;
+        }
 
         if (currentTab != null
                 && (currentTab.isNativePage() || NewTabPage.isNTPUrl(currentTab.getUrl()))) {

chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeExperimentsUtil.java

@@ -88,9 +88,7 @@ public final class ReturnToChromeExperimentsUtil {
      * @param transition The page transition type.
      * @return true if we have handled the navigation, false otherwise.
      */
-    // TODO(mattsimmons): This needs to be updated for MV tiles to record the correct metrics.
-    // TODO(mattsimmons): Rename/Refactor since it's not just location bar now.
-    public static boolean willHandleLoadUrlFromLocationBar(
+    public static boolean willHandleLoadUrlFromStartSurface(
             String url, @PageTransition int transition) {
         ChromeActivity chromeActivity = getActivityPresentingOverviewWithOmnibox();
         if (chromeActivity == null) return false;
@@ -102,11 +100,15 @@ public final class ReturnToChromeExperimentsUtil {
         chromeActivity.getTabCreator(model.isIncognito())
                 .createNewTab(params, TabLaunchType.FROM_CHROME_UI, null);
 
-        RecordUserAction.record("MobileOmniboxUse.GridTabSwitcher");
+        if (transition == PageTransition.AUTO_BOOKMARK) {
+            RecordUserAction.record("Suggestions.Tile.Tapped.GridTabSwitcher");
+        } else {
+            RecordUserAction.record("MobileOmniboxUse.GridTabSwitcher");
 
-        // These are duplicated here but would have been recorded by LocationBarLayout#loadUrl.
-        RecordUserAction.record("MobileOmniboxUse");
-        LocaleManager.getInstance().recordLocaleBasedSearchMetrics(false, url, transition);
+            // These are duplicated here but would have been recorded by LocationBarLayout#loadUrl.
+            RecordUserAction.record("MobileOmniboxUse");
+            LocaleManager.getInstance().recordLocaleBasedSearchMetrics(false, url, transition);
+        }
 
         return true;
     }