Skip to content

GitLab

T
tangled
Commit c99b682a authored by Majid Valipour's avatar Majid Valipour Committed by Commit Bot
Browse files
Options

Reland "[animation-worklet] Rename layout tests" 

This reverts commit a08572dc.

Reason for revert: the original revert was a mistake. The
test is flaky regardless of this CL.


Original change's description:
> Revert "[animation-worklet] Rename layout tests"
> 
> This reverts commit 46b03fcf.
> 
> Reason for revert:
> 
> Seems to break fast/events/middleClickAutoscroll-nested-divs.html on several platforms. Example here:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34202
> 
> 
> Original change's description:
> > [animation-worklet] Rename layout tests
> > 
> > Remove "animation-worklet-' prefix from layout tests. The tests are inside AW
> > directory so the prefix is just visual clutter. I kept it for tests that check
> > something about the worklet itself.
> > 
> > Note: There was a legacy unused animationworklet/visual-update-expected.html
> > file that this patch replaces now.
> > 
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad
> > Reviewed-on: https://chromium-review.googlesource.com/1165271
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Yi Gu <yigu@chromium.org>
> > Commit-Queue: Majid Valipour <majidvp@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581552}
> 
> TBR=majidvp@chromium.org,yigu@chromium.org
> 
> Change-Id: If81712c7089784772b5a106159c70bdd7cbce9c8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1167766
> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581653}

TBR=hubbe@chromium.org,majidvp@chromium.org,yigu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icc031d3f40d537316005f0ba7b79a6d8858c9720
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1173071
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Reviewed-by: default avatarMajid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582718}
parent 2b56601a
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 54 deletions
third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-visual-update-expected.html deleted 100644 → 0
View file @ 2b56601a
<!DOCTYPE html>
<style>
#box {
width: 100px;
height: 100px;
background-color: #00ff00;
transform: translate(0, 100px);
opacity: 0.5;
will-change: transform; /* force compositing */
}
#covered {
width: 100px;
height: 100px;
background-color: #ff8080;
}
</style>
<div id="box"></div>
<div id="covered"></div>
third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/visual-update-expected.html
View file @ c99b682a
<!DOCTYPE html> <!DOCTYPE html>
<!--
Tests that a change from the worker produces a visual update.
-->
<style> <style>
#box { #box {
width: 100px; width: 100px;
height: 100px; height: 100px;
/* A composited DIV background is clipped differently from a non-composited background-color: #00ff00;
one. This causes the box to be composited in both cases transform: translate(0, 100px);
TODO(majidvp): fix this mismatch between CC and blink rendering opacity: 0.5;
*/ will-change: transform; /* force compositing */
backface-visibility: hidden;
}
#covered, #green {
width: 85px;
height: 85px;
} }
#box, #covered { #covered {
width: 100px;
height: 100px;
background-color: #ff8080; background-color: #ff8080;
overflow: auto;
} }
#green {
position: relative;
left: 100px;
top: 100px;
background-color: #00ff00;
}
</style> </style>
<div id="box"> <div id="box"></div>
<div id="green"></div>
</div>
<div id="covered"></div> <div id="covered"></div>
<script>
var box = document.getElementById('box');
box.style.transform = 'translate(0, 100px)';
box.style.opacity = 0.5;
box.scrollLeft = 100;
box.scrollTop = 100;
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment