Orderfile: use reliable package killing.
The device_utils.KillAll command is not reliable for chrome. This command uses `ps` on the device to enumerate all pids for a package, and then does a `kill` for each pid. If, for example, a chrome browser process is killed by the host, and a dependent renderer process dies before the host can get around to killing it, device_utils.KillAll will think that the kill failed and raise an exception. This could be circumvented either by passing quiet=True to KillAll, or by using the activity manager force-stop command, as is done in the CL. This latter method seems to be the current preferred way to gracefully kill all processes of a package. Bug: 898979 Change-Id: I0451c04b1d9e9ab919dde5e12df247fce3a7651a Reviewed-on: https://chromium-review.googlesource.com/c/1329152 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607532}
Showing
Please register or sign in to comment