Commit c9c16ab3 authored by xiyuan@chromium.org's avatar xiyuan@chromium.org

[ChromeOS] WebUILoginView returns true for IsPopupOrPanel.

This makes WebUILoginView not a drag-n-drop target as TabContents::ShouldAcceptDragAndDrop would return false now. Besides, WebUILoginView is popup in some sense.

BUG=chromium-os:18781
TEST=Verify crash no longer happens for chromium-os:18781.


Review URL: http://codereview.chromium.org/7640023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96636 0039d316-1c4b-4281-b951-d872f2087c98
parent 31aa30be
......@@ -248,6 +248,10 @@ bool WebUILoginView::HandleContextMenu(const ContextMenuParams& params) {
#endif
}
bool WebUILoginView::IsPopupOrPanel(const TabContents* source) const {
return true;
}
bool WebUILoginView::TakeFocus(bool reverse) {
// Forward the focus back to web contents.
webui_login_->tab_contents()->FocusThroughTabTraversal(reverse);
......
......@@ -110,8 +110,10 @@ class WebUILoginView : public views::View,
// Overridden from TabContentsDelegate.
virtual bool HandleContextMenu(const ContextMenuParams& params) OVERRIDE;
virtual void HandleKeyboardEvent(
const NativeWebKeyboardEvent& event) OVERRIDE;
virtual bool IsPopupOrPanel(const TabContents* source) const OVERRIDE;
virtual bool TakeFocus(bool reverse) OVERRIDE;
virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
// Window that contains status area.
// TODO(nkostylev): Temporary solution till we have
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment