Commit c9c1768b authored by Nicholas Hollingum's avatar Nicholas Hollingum Committed by Commit Bot

Remove redundant call to determine crostini app id

This is done by AppServiceAppWindowCrostiniTracker::GetShelfAppId before
this point always, and the subsequent call will always return the same
thing.

The claim in the comment is probably legacy, as empty-app-id windows
will be filtered out by
AppServiceAppWindowLauncherController::OnWindowVisibilityChanged.

Bug: b/172979315
Change-Id: I38121c68cb48c9840831b83665fdf7e33285cc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552327Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#830097}
parent b45476bb
......@@ -101,13 +101,6 @@ void AppServiceAppWindowCrostiniTracker::OnWindowVisibilityChanged(
Profile* primary_account_profile =
chromeos::ProfileHelper::Get()->GetProfileByAccountId(primary_account_id);
// Windows without an application id set will get filtered out here.
const std::string& crostini_shelf_app_id = crostini::GetCrostiniShelfAppId(
primary_account_profile, exo::GetShellApplicationId(window),
exo::GetShellStartupId(window));
if (crostini_shelf_app_id.empty())
return;
auto* registry_service =
guest_os::GuestOsRegistryServiceFactory::GetForProfile(
primary_account_profile);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment