Commit c9cf6677 authored by hyatt's avatar hyatt

While optimizing form controls and fixing their clipping, I caused...

        While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
        of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
        bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
        as dirty when we don't have to.

        Reviewed by mitz

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):



git-svn-id: svn://svn.chromium.org/blink/trunk@18836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 2ba297f8
2007-01-13 David Hyatt <hyatt@apple.com>
While optimizing form controls and fixing their clipping, I caused this text zoom regression. The layout
of text is necessary because it needs to recalc minmaxwidth. This is still a really unfortunate
bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
as dirty when we don't have to.
Reviewed by mitz
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
2007-01-13 Lars Knoll <lars@trolltech.com>
Reviewed by Alexey
......
......@@ -2319,7 +2319,9 @@ void RenderObject::setStyle(RenderStyle* style)
// No need to ever schedule repaints from a style change of a text run, since
// we already did this for the parent of the text run.
if (d == RenderStyle::Layout && m_parent && !isText())
// We do have to schedule layouts, though, since a style change can force us to
// need to relayout.
if (d == RenderStyle::Layout && m_parent)
setNeedsLayoutAndMinMaxRecalc();
else if (m_parent && !isText() && (d == RenderStyle::RepaintLayer || d == RenderStyle::Repaint))
// Do a repaint with the new style now, e.g., for example if we go from
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment