Commit c9ed083c authored by ericrk's avatar ericrk Committed by Commit bot

Re-enable GPU partial raster for non-MSAA content

This re-enables GPU partial raster for non-MSAA content. MSAA resolve
does not work well with partial raster right now - we may try to address
this in the future.

BUG=629683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2161933004
Cr-Commit-Position: refs/heads/master@{#406642}
parent ba44cdfb
...@@ -226,7 +226,10 @@ bool GpuRasterBufferProvider::IsResourceSwizzleRequired( ...@@ -226,7 +226,10 @@ bool GpuRasterBufferProvider::IsResourceSwizzleRequired(
} }
bool GpuRasterBufferProvider::CanPartialRasterIntoProvidedResource() const { bool GpuRasterBufferProvider::CanPartialRasterIntoProvidedResource() const {
return false; // Partial raster doesn't support MSAA, as the MSAA resolve is unaware of clip
// rects.
// TODO(crbug.com/629683): See if we can work around this limitation.
return msaa_sample_count_ == 0;
} }
void GpuRasterBufferProvider::Shutdown() { void GpuRasterBufferProvider::Shutdown() {
......
...@@ -223,10 +223,8 @@ TEST_F(LayerTreeHostTilesTestPartialInvalidation, ...@@ -223,10 +223,8 @@ TEST_F(LayerTreeHostTilesTestPartialInvalidation,
base::FilePath(FILE_PATH_LITERAL("blue_yellow_flipped.png"))); base::FilePath(FILE_PATH_LITERAL("blue_yellow_flipped.png")));
} }
// TODO(crbug.com/629683): Re-enable this test once GPU partial raster issues
// are fixed.
TEST_F(LayerTreeHostTilesTestPartialInvalidation, TEST_F(LayerTreeHostTilesTestPartialInvalidation,
DISABLED_PartialRaster_SingleThread_GpuRaster) { PartialRaster_SingleThread_GpuRaster) {
RunRasterPixelTest( RunRasterPixelTest(
false, PARTIAL_GPU, picture_layer_, false, PARTIAL_GPU, picture_layer_,
base::FilePath(FILE_PATH_LITERAL("blue_yellow_partial_flipped.png"))); base::FilePath(FILE_PATH_LITERAL("blue_yellow_partial_flipped.png")));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment